Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session properties for scaled table scan configs to coordinator #24284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

natashasehgal
Copy link

@natashasehgal natashasehgal commented Dec 19, 2024

Description

Add session properties to Java coordinator for to scale table scan

table_scan_scaled_processing_enabled
table_scan_scale_up_memory_usage_ratio

Follow up: Add these parameters to Native workers #24275

Motivation and Context

Impact

Low impact

Test Plan

  • CI Tests passed

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@natashasehgal natashasehgal requested a review from a team as a code owner December 19, 2024 07:25
@natashasehgal natashasehgal changed the title Add session properties for scaled table scan configs Add session properties for scaled table scan configs to Coordinator Dec 20, 2024
@gggrace14
Copy link
Contributor

The change to the Java documentation should go together with this change to the coordinator. You can include your original patch to presto-docs/src/main/sphinx/presto_cpp/properties-session.rst in this PR.

Logically, supposed the OSS community see this change and would like to look for more info, they could find the Java documentation in the codebase.

Usually the files under presto-native-execution belong to the native C++ worker and are packaged and released together. Everything else belongs to the Java coordinator.

@gggrace14
Copy link
Contributor

We always have the Description section filled out. Other sections could be possibly skipped if not applicable. You can move your content under Motivation to Description.

@natashasehgal natashasehgal changed the title Add session properties for scaled table scan configs to Coordinator Add session properties for scaled table scan configs to coordinator Dec 20, 2024
@gggrace14
Copy link
Contributor

Thank you @natashasehgal for making the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants