Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session properties for scaled table scan configs to coordinator #24284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add session properties for scaled table scan configs to coordinator #24284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bea1d1
Add session properties for scaled table scan configs
natashasehgal Dec 19, 2024
5340b2f
add documentation for new table scan session properties
natashasehgal Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions presto-docs/src/main/sphinx/presto_cpp/properties-session.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,3 +419,24 @@ writer scaling if it is detected as overloaded by scale writer exchange.

Minimum amount of data processed by all the logical table partitions to
trigger skewed partition rebalancing by scale writer exchange.

``native_table_scan_scaled_processing_enabled``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

* **Type:** ``boolean``
* **Default value:** ``false``

Enables scaled processing for table scans.
When enabled, Presto will attempt to scale up table scans to improve performance.

``native_table_scan_scale_up_memory_usage_ratio``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

* **Type:** ``double``
* **Minimum value:** ``0``
* **Maximum value:** ``1``
* **Default value:** ``0.7``

Controls the ratio of available memory that can be used for scaling up table scans.
A higher value allows more memory to be allocated for scaling up table scans,
while a lower value limits the amount of memory used.
16 changes: 16 additions & 0 deletions ...ava/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ public class NativeWorkerSessionPropertyProvider
public static final String NATIVE_SCALED_WRITER_MAX_PARTITIONS_PER_WRITER = "native_scaled_writer_max_partitions_per_writer";
public static final String NATIVE_SCALED_WRITER_MIN_PARTITION_PROCESSED_BYTES_REBALANCE_THRESHOLD = "native_scaled_writer_min_partition_processed_bytes_rebalance_threshold";
public static final String NATIVE_SCALED_WRITER_MIN_PROCESSED_BYTES_REBALANCE_THRESHOLD = "native_scaled_writer_min_processed_bytes_rebalance_threshold";
public static final String NATIVE_TABLE_SCAN_SCALED_PROCESSING_ENABLED = "native_table_scan_scaled_processing_enabled";
public static final String NATIVE_TABLE_SCAN_SCALE_UP_MEMORY_USAGE_RATIO = "native_table_scan_scale_up_memory_usage_ratio";
private final List<PropertyMetadata<?>> sessionProperties;

@Inject
Expand Down Expand Up @@ -309,6 +311,20 @@ public NativeWorkerSessionPropertyProvider(FeaturesConfig featuresConfig)
"Minimum amount of data processed by all the logical table partitions " +
"to trigger skewed partition rebalancing by scale writer exchange.",
256L << 20,
!nativeExecution),
booleanProperty(
NATIVE_TABLE_SCAN_SCALED_PROCESSING_ENABLED,
"If set to true, enables the scaled table scan processing.",
false,
!nativeExecution),
doubleProperty(
NATIVE_TABLE_SCAN_SCALE_UP_MEMORY_USAGE_RATIO,
"The query memory usage ratio used by scan controller to decide if it can " +
"increase the number of running scan threads. When the query memory usage " +
"is below this ratio, the scan controller keeps increasing the running scan " +
"thread for scale up, and stop once exceeds this ratio. The value is in the " +
"range of [0, 1].",
0.7,
!nativeExecution));
}

Expand Down
Loading