Fix circuit benchmarks

[zemse]

Description

This PR aims to get the benchmark tests running.

Issue Link

#1646

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Contents

• Updates default degree in the benchmark tests

Rationale

[design decisions and extended information]

How Has This Been Tested?

cargo test --release --features=benches bytecode
cargo test --release --features=benches copy
cargo test --release --features=benches evm
cargo test --release --features=benches exp
cargo test --release --features=benches mpt
cargo test --release --features=benches keccak
cargo test --release --features=benches pi
cargo test --release --features=benches state
cargo test --release --features=benches super
cargo test --release --features=benches tx

[zemse]

Two benchmark tests are failing: bytecode & copy from this PR. The following are errors that seem to be coming from dependencies:

---- bytecode_circuit::tests::bench_bytecode_circuit_prover stdout ----
Start:   Bytecode Circuit [Setup generation] with degree = 26
End:     Bytecode Circuit [Setup generation] with degree = 26 ......................1128.019s
thread 'bytecode_circuit::tests::bench_bytecode_circuit_prover' panicked at 'assertion failed: `(left == right)`
  left: `4`,
 right: `8`', /home/ubuntu/.cargo/git/checkouts/halo2-afe2d0b0be6b3c3a/be95568/halo2_proofs/src/poly/domain.rs:101:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- copy_circuit::tests::bench_copy_circuit_prover stdout ----
Start:   Copy Circuit [Setup generation] with degree = 14
End:     Copy Circuit [Setup generation] with degree = 14 ..........................589.546ms
Start:   Copy Circuit [Proof generation] with degree = 14
End:     Copy Circuit [Proof generation] with degree = 14 ..........................160.797ms
Start:   Copy Circuit [Proof verification]
thread 'copy_circuit::tests::bench_copy_circuit_prover' panicked at 'assertion failed: (input == 0u8) | (input == 1u8)', /Users/sohamzemse/.cargo/registry/src/index.crates.io-6f17d22bba15001f/subtle-2.5.0/src/lib.rs:230:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[ChihChengLiang]

I tried to look into the two failing benchmarks and didn't find quick solutions.
Share you some of my initial thoughts.

[ChihChengLiang]

It could be that 26 is too big so that it triggers the Halo2 error. We can try tweaking somewhere else.

I changed line 52 from 2usize.pow(degree), to 2usize.pow(degree - 1), and got a ConstraintSystemFailure instead.

We can also create a new issue to specifically fix bytecode circuit benchmark.

[ChihChengLiang]

I think we have to calculate this to get a number that works. We can fix in the next PR.

[zemse]

@ChihChengLiang thanks for taking a look!

[ChihChengLiang]

LGTM.
IIUC, after this PR, we should have the rest of the benchmarks working.
Bytecode and copy circuit remain failing and will be fixed in future PRs.

[rrtoledo]

LGTM with the changes CC mentioned! :)

[ChihChengLiang]

I created #1694 and #1695 for the benchmarks to fix.