Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Fix circuit benchmarks #1686

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/bytecode_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ mod tests {
let proof_gen_prfx = crate::constants::PROOFGEN_PREFIX;
let proof_ver_prfx = crate::constants::PROOFVER_PREFIX;
let degree: u32 = var("DEGREE")
.unwrap_or_else(|_| "15".to_string())
.unwrap_or("26".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
7 changes: 4 additions & 3 deletions circuit-benchmarks/src/copy_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ mod tests {
let proof_gen_prfx = crate::constants::PROOFGEN_PREFIX;
let proof_ver_prfx = crate::constants::PROOFVER_PREFIX;
let degree: u32 = var("DEGREE")
.unwrap_or_else(|_| "14".to_string())
.unwrap_or("14".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand All @@ -51,9 +51,10 @@ mod tests {
]);

// Create the circuit
let block = generate_full_events_block(degree);
let mut block = generate_full_events_block(degree);
block.circuits_params.max_rws = 10_000;
block.circuits_params.max_copy_rows = 10_000;
Comment on lines +55 to +56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to calculate this to get a number that works. We can fix in the next PR.

let circuit = TestCopyCircuit::<Fr>::new_from_block(&block);

// Bench setup generation
let setup_message = format!("{} {} with degree = {}", BENCHMARK_ID, setup_prfx, degree);
let start1 = start_timer!(|| setup_message);
Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/evm_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ mod evm_circ_benches {
const BENCHMARK_ID: &str = "EVM Circuit";

let degree: u32 = var("DEGREE")
.expect("No DEGREE env var was provided")
.unwrap_or("18".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/exp_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ mod tests {
// Initialize the circuit

let degree: u32 = var("DEGREE")
.unwrap_or_else(|_| "19".to_string())
.unwrap_or("10".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/mpt_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ mod tests {
const BENCHMARK_ID: &str = "MPT Circuit";

let degree: u32 = var("DEGREE")
.expect("No DEGREE env var was provided")
.unwrap_or("15".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/packed_multi_keccak.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ mod tests {
const BENCHMARK_ID: &str = "Packed Multi-Keccak Circuit";

let degree: u32 = var("DEGREE")
.expect("No DEGREE env var was provided")
.unwrap_or("11".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/pi_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ mod tests {
const MAX_CALLDATA: usize = 128;

let degree: u32 = var("DEGREE")
.unwrap_or_else(|_| "19".to_string())
.unwrap_or("17".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/state_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ mod tests {
const BENCHMARK_ID: &str = "State Circuit";

let degree: u32 = var("DEGREE")
.expect("No DEGREE env var was provided")
.unwrap_or("18".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/super_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ mod tests {
const BENCHMARK_ID: &str = "Super Circuit";

let degree: u32 = var("DEGREE")
.expect("No DEGREE env var was provided")
.unwrap_or("19".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
2 changes: 1 addition & 1 deletion circuit-benchmarks/src/tx_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ mod tests {
const MAX_CALLDATA: usize = 1024;

let degree: u32 = var("DEGREE")
.unwrap_or_else(|_| "19".to_string())
.unwrap_or("19".to_string())
.parse()
.expect("Cannot parse DEGREE env var as u32");

Expand Down
Loading