Fix inputhook implementation to be compatible with asyncio.run(). #1810
+52
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2023
jonathanslenders
force-pushed
the
fix-eventloop-inputhook
branch
9 times, most recently
from
97707e9
to
375705d
Compare
`asyncio.get_event_loop()` got deprecated. So we can't install an event loop with inputhook upfront and then use in in prompt_toolkit. Instead, we can take the inputhook as an argument in `Application.run()` and `PromptSession.run()`, and install it in the event loop that we create ourselves using `asyncio.run()`.
jonathanslenders
force-pushed
the
fix-eventloop-inputhook
branch
from
375705d
to
606033a
Compare
Carreau
added a commit
to ipython/ipython
that referenced
this pull request
Nov 20, 2023
…sion.run(). (#14241) See: prompt-toolkit/python-prompt-toolkit#1809 To summarize: - In prompt_toolkit, some changes were done to get rid of a deprecation warning related to the usage of `set_event_loop()` on Python 3.12. It looks like IPython did had a workaround for the deprecation warning, but Xonsh for instance did not. Now, the code that was fixed in prompt_toolkit breaks input hooks in IPython. - The right thing to do would be to accept the input hook as an argument in prompt_toolkit, which is what this PR does: prompt-toolkit/python-prompt-toolkit#1810 - For IPython, we have to do a similar change to pass it as an argument (this PR). It's not well tested (I'm not using IPython with inputhooks myself). I'm also not very familiar myself with IPython's code base. I think it requires some coordination. I'm not sure if there's a way to be backward compatible. I guess if I push a new prompt_toolkit version with the fix on my side, nothing will break, but input hooks will for sure not work on any Python version until this is merged. We should probably set the minimum prompt_toolkit version after merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.get_event_loop()got deprecated. So we can't install an event loop with inputhook upfront and then use in in prompt_toolkit. Instead, we can take the inputhook as an argument inApplication.run()andPromptSession.run(), and install it in the event loop that we create ourselves usingasyncio.run().