Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lleone/memisland #41

Merged
merged 1 commit into from
Sep 30, 2024
Merged

lleone/memisland #41

merged 1 commit into from
Sep 30, 2024

Conversation

Lore0599
Copy link

@Lore0599 Lore0599 commented Sep 24, 2024

Memory Island Integration

This PR relocates the Memory Island IP from Cheshire and integrates it into the Chimera SoC module. The goal is to isolate the memory into a separate domain, allowing it to be managed independently from the power domain perspective.

Added

HW:

  • chimera_memisland_domain: This module represents the memory domain and will be used in the PMU as an internal Power Domain of the Chimera SoC.
  • chimera_cfg_t: Since the memory island is now external to Cheshire, a new structure has been created inside chimera_pkg to include Cheshire's configuration struct along with the memory island information. As a result, all hardware modules and testbench files have been adapted to accommodate the new configuration type.

SW:

  • CHS_SW_LD_DIR: This flag has been introduced in the software stack to build Cheshire's bootrom according to Chimera’s memory map, which now includes the memory island. It is the directory where the compiler can find the necessary linker scripts.

Copy link
Collaborator

@Scheremo Scheremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, minor comments.

chimera.mk Outdated Show resolved Hide resolved
hw/chimera_pkg.sv Outdated Show resolved Hide resolved
@Lore0599 Lore0599 force-pushed the lleone/memisland branch 6 times, most recently from 0fcb164 to e7fb85e Compare September 27, 2024 14:04
@Lore0599 Lore0599 marked this pull request as ready for review September 27, 2024 14:15
@Lore0599 Lore0599 requested a review from Scheremo September 27, 2024 15:16
@Lore0599 Lore0599 requested review from viv-eth and removed request for micprog September 27, 2024 15:29
@Lore0599 Lore0599 force-pushed the lleone/memisland branch 2 times, most recently from f7722e2 to 829ac71 Compare September 30, 2024 06:43
Hw: - Add memory island domain wrapper
    - chimera_cfg_t struct & typedef for AXI signals
    - New Memory island address mappin
Sw: Add support to build chehsire bootrom for mem island integration
@Lore0599 Lore0599 merged commit e7a9ace into devel Sep 30, 2024
6 checks passed
@Lore0599 Lore0599 deleted the lleone/memisland branch September 30, 2024 07:08
Comment on lines +20 to +21
input axi_narrow_req_t axi_narrow_req_i,
output axi_narrow_rsp_t axi_narrow_rsp_o,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point you may want to break up the chs xbar and add individual narrow ports to the memory island for each master, see https://github.com/pulp-platform/cheshire/blob/michaero/chimera/hw/cheshire_soc.sv#L247-L311

sermazz pushed a commit that referenced this pull request Oct 23, 2024
Hw: - Add memory island domain wrapper
    - chimera_cfg_t struct & typedef for AXI signals
    - New Memory island address mappin
Sw: Add support to build chehsire bootrom for mem island integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants