-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Hyperbus peripheral #47
Conversation
19cbd63
to
d1090d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
e8e14e2
to
a91fe71
Compare
5f569cd
to
d1090d3
Compare
d1090d3
to
abdb469
Compare
abdb469
to
0c20226
Compare
0c20226
to
840a1dd
Compare
@Lore0599 @arpansur @Scheremo @adimauro-iis |
I think both are blocking but trivial to resolve. You can extend the register memory map range (0x3000_0000 - 0x4000_0000) contiguously with the config registers and map the hyperbus memory "somewhere reasonable" (why not 0x5000_0000?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly fine to me, some comments sprinkled throughout. Is there some consideration behind having two PHYs? I understand two endpoints (HyperRAM and HyperFlash), but that should only necessitate another CS pin.
e5e8dec
to
6ba5d20
Compare
Should be ready to merge.
You can check the last commits that I added. Let me know if there's any further feedback :) |
Hey Sergio, thanks for the effort! All my comments are satisfied; we might want to add a few more large-scale tests, but the RTL looks mergeable to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please just fix the failing pipeline.
9e94e61
to
b9719b2
Compare
This PR:
integrates the Hyperbus peripheral in the Chimera top RTL
integrates the HyperRAM VIP in the Chimera testbench
adds an addressability test for the Hyperbus and adds it to the CI
Config registers are still to be added add config registers to hyperbus #43
What address range should we use for the HyperRAM? https://github.com/pulp-platform/chimera/blob/smazzola/hyperbus/hw/chimera_pkg.sv#L128-L130