Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Hyperbus peripheral #47

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Integrate Hyperbus peripheral #47

merged 9 commits into from
Nov 4, 2024

Conversation

sermazz
Copy link

@sermazz sermazz commented Oct 4, 2024

This PR:

@sermazz sermazz changed the base branch from main to devel October 4, 2024 18:17
@sermazz sermazz force-pushed the smazzola/hyperbus branch 5 times, most recently from 19cbd63 to d1090d3 Compare October 7, 2024 12:02
Copy link

@Lore0599 Lore0599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

hw/chimera_top_wrapper.sv Outdated Show resolved Hide resolved
sw/tests/testHyperbusAddr.c Outdated Show resolved Hide resolved
hw/chimera_pkg.sv Show resolved Hide resolved
hw/chimera_pkg.sv Outdated Show resolved Hide resolved
@sermazz sermazz force-pushed the smazzola/hyperbus branch from e8e14e2 to a91fe71 Compare October 8, 2024 09:55
@sermazz sermazz changed the title Integrate Hyperbus peripheral and test infrastructure Integrate Hyperbus integration + stack pointer fix Oct 8, 2024
@sermazz sermazz force-pushed the smazzola/hyperbus branch from 5f569cd to d1090d3 Compare October 8, 2024 11:17
@sermazz sermazz changed the title Integrate Hyperbus integration + stack pointer fix Integrate Hyperbus peripheral Oct 8, 2024
@sermazz sermazz force-pushed the smazzola/hyperbus branch from d1090d3 to abdb469 Compare October 8, 2024 11:52
@sermazz sermazz requested a review from Lore0599 October 17, 2024 11:36
@sermazz
Copy link
Author

sermazz commented Oct 17, 2024

@Lore0599 @arpansur @Scheremo @adimauro-iis
CI is finally passing after the fixes on devel, we should now define the range we need for HyperRAM (https://github.com/pulp-platform/chimera/pull/47/files#diff-7310782802ac0d64363e8ceb9e90e54a5c0c858fc1e63688d48ad6964dd3fb4bR131). And also have a plan for #43.
If these are not blocking, we can merge.

@Scheremo
Copy link
Collaborator

@Lore0599 @arpansur @Scheremo @adimauro-iis CI is finally passing after the fixes on devel, we should now define the range we need for HyperRAM (https://github.com/pulp-platform/chimera/pull/47/files#diff-7310782802ac0d64363e8ceb9e90e54a5c0c858fc1e63688d48ad6964dd3fb4bR131). And also have a plan for #43. If these are not blocking, we can merge.

I think both are blocking but trivial to resolve. You can extend the register memory map range (0x3000_0000 - 0x4000_0000) contiguously with the config registers and map the hyperbus memory "somewhere reasonable" (why not 0x5000_0000?)

bender.mk Show resolved Hide resolved
Copy link
Collaborator

@Scheremo Scheremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine to me, some comments sprinkled throughout. Is there some consideration behind having two PHYs? I understand two endpoints (HyperRAM and HyperFlash), but that should only necessitate another CS pin.

Bender.yml Show resolved Hide resolved
hw/chimera_top_wrapper.sv Outdated Show resolved Hide resolved
hw/chimera_pkg.sv Outdated Show resolved Hide resolved
hw/chimera_top_wrapper.sv Outdated Show resolved Hide resolved
target/sim/src/vip_chimera_soc.sv Show resolved Hide resolved
@sermazz sermazz requested review from Scheremo and Lore0599 November 1, 2024 15:30
@sermazz
Copy link
Author

sermazz commented Nov 1, 2024

Should be ready to merge.

  • I integrated Morit's fixes from b67f438 and further fixed some small stuff
  • Fixed the linting
  • Connected the hyperbus peripheral to the regbus by instantiating another external regbus port in Cheshire

You can check the last commits that I added. Let me know if there's any further feedback :)

@Scheremo
Copy link
Collaborator

Scheremo commented Nov 1, 2024

Should be ready to merge.

  • I integrated Morit's fixes from b67f438 and further fixed some small stuff
  • Fixed the linting
  • Connected the hyperbus peripheral to the regbus by instantiating another external regbus port in Cheshire

You can check the last commits that I added. Let me know if there's any further feedback :)

Hey Sergio, thanks for the effort! All my comments are satisfied; we might want to add a few more large-scale tests, but the RTL looks mergeable to me.

Copy link
Collaborator

@Scheremo Scheremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please just fix the failing pipeline.

@sermazz sermazz merged commit 314e947 into devel Nov 4, 2024
6 checks passed
@DanielKellerM DanielKellerM deleted the smazzola/hyperbus branch November 12, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants