Various cleanup #43
Various cleanup #43
Conversation
micprog
commented
Feb 9, 2024
micprog
commented
- Update build flow/testbench
- Fix testbench for badly addressed bursts
- Add types to all parameters
- Replace AXI interfaces with structs
Fixes r.last signal for accidental bursts to apb
|
I can also split this PR up a bit, there are quite a few changes coming together here... |
There was a problem hiding this comment.
The PR looks good to me. I just noticed that the DMA tests [do not even start])https://iis-git.ee.ethz.ch/github-mirror/pulp_cluster/-/jobs/996194#L26), and the same is for the parallel bare tests.
micprog
force-pushed
the
michaero/cleanup-2
branch
from
db3e67a to
db4b58b
Compare
|
There were some more issues due to bad testing on my part, sorry. Should be fixed now (with some speed improvements and no more warnings). Might also be worth it to ensure the CI works properly and reports fails when it should... |
I think the problem is that the CI greps for a fatal or some error message (linked to the returned value I think) to understand if a failed, and if the grep does not succeed (as in the case of a test that did not even start) it just returns success. I agree that this should be improved. Also making the regressions' outputs more homogeneous (like all of them printing either "Success!" or "Failed!" at the end) could maybe help. |
* Add `run_and_exit.tcl`; use specific commits for regressions and runtime. * Update nonfree flow * Fix environment sourcing * Adapt run scripts to use VSIM. * Add error suppression for WLF logging. --------- Co-authored-by: Yvan Tortorella <ytortorella@lagrev3.ee.ethz.ch> Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
|
Everything seems fine now, CI is passing. Merging now. |
