Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDKv2 detailed diff set tests for top-level ForceNew #2724

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 11, 2024

This change adds SDKv2 detailed diff tests for top-level ForceNew sets.

Some of the test permutations are skipped because we discovered some unnecessary replacements on our side. This is tracked in #2726

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (5b45441) to head (d168ffb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2724   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         301      301           
  Lines       38726    38726           
=======================================
  Hits        26971    26971           
  Misses      10237    10237           
  Partials     1518     1518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from e34124f to 77ebeec Compare December 11, 2024 18:05
@VenelinMartinov VenelinMartinov changed the title SDKv2 detailed diff set tests for replacement Refactor SDKv2 detailed diff set tests for replacement Dec 11, 2024
@VenelinMartinov VenelinMartinov changed the title Refactor SDKv2 detailed diff set tests for replacement SDKv2 detailed diff set tests for top-level ForceNew Dec 11, 2024
@VenelinMartinov VenelinMartinov changed the title SDKv2 detailed diff set tests for top-level ForceNew Add SDKv2 detailed diff set tests for top-level ForceNew Dec 11, 2024
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from 77ebeec to eddfb59 Compare December 12, 2024 11:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_pulcheck_id_and_update branch from 40369a1 to a350c93 Compare December 12, 2024 12:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from eddfb59 to 7345fe0 Compare December 12, 2024 12:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_pulcheck_id_and_update branch from a350c93 to 2e69e46 Compare December 12, 2024 15:20
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from 7345fe0 to b2b8cf9 Compare December 12, 2024 15:20
id = "newid"

- test {
- nested = "value" -> null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan here is weird!

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-checking a few, looks reasonable!

@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_pulcheck_id_and_update branch from 2e69e46 to 0f1206a Compare December 13, 2024 16:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_set_replace branch from b2b8cf9 to d168ffb Compare December 13, 2024 16:33
Base automatically changed from vvm/sdkv2_pulcheck_id_and_update to master December 13, 2024 17:39
@VenelinMartinov VenelinMartinov merged commit e84de3f into master Dec 13, 2024
31 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/sdkv2_detailed_diff_set_replace branch December 13, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants