-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SDKv2 set detailed diff tests to correct files #2741
Open
VenelinMartinov
wants to merge
1
commit into
vvm/sdkv2_detailed_diff_computed_in_sets
Choose a base branch
from
vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files
base: vvm/sdkv2_detailed_diff_computed_in_sets
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor SDKv2 set detailed diff tests to correct files #2741
VenelinMartinov
wants to merge
1
commit into
vvm/sdkv2_detailed_diff_computed_in_sets
from
vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Dec 12, 2024
VenelinMartinov
changed the title
refactor sdkv2 set detailed diff tests to correct files
Refactor SDKv2 set detailed diff tests to correct files
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## vvm/sdkv2_detailed_diff_computed_in_sets #2741 +/- ##
=========================================================================
Coverage 69.64% 69.64%
=========================================================================
Files 301 301
Lines 38726 38726
=========================================================================
Hits 26969 26969
Misses 10240 10240
Partials 1517 1517 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files
branch
from
December 12, 2024 15:31
4a4c0ed
to
a866f4b
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_detailed_diff_computed_in_sets
branch
from
December 13, 2024 16:34
7c5f7c4
to
d8b1526
Compare
VenelinMartinov
force-pushed
the
vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files
branch
from
December 13, 2024 16:34
a866f4b
to
e4e5bb7
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_detailed_diff_computed_in_sets
branch
from
December 13, 2024 17:42
d8b1526
to
bd80587
Compare
VenelinMartinov
force-pushed
the
vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files
branch
from
December 13, 2024 17:42
e4e5bb7
to
9aa9385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes some of the tests which are now made redundant by equivalent cross-tests and moves the tests for unknowns sets to
detailed_diff_unknown_test.go