Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SDKv2 set detailed diff tests to correct files #2741

Open
wants to merge 1 commit into
base: vvm/sdkv2_detailed_diff_computed_in_sets
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 12, 2024

This PR deletes some of the tests which are now made redundant by equivalent cross-tests and moves the tests for unknowns sets to detailed_diff_unknown_test.go

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (bd80587) to head (9aa9385).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           vvm/sdkv2_detailed_diff_computed_in_sets    #2741   +/-   ##
=========================================================================
  Coverage                                     69.64%   69.64%           
=========================================================================
  Files                                           301      301           
  Lines                                         38726    38726           
=========================================================================
  Hits                                          26969    26969           
  Misses                                        10240    10240           
  Partials                                       1517     1517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 4a4c0ed to a866f4b Compare December 12, 2024 15:31
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 7c5f7c4 to d8b1526 Compare December 13, 2024 16:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from a866f4b to e4e5bb7 Compare December 13, 2024 16:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from d8b1526 to bd80587 Compare December 13, 2024 17:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from e4e5bb7 to 9aa9385 Compare December 13, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant