Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) add ed25519 support #3248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Nov 22, 2023

rubygems has compiled releases of bcrypt_pbkdf >= 1.1.0 for windows, and >= 1.1.1 compile correctly on all supported ruby platform/compiler combinations.

addresses #1987

@h0tw1r3 h0tw1r3 added the Feature New features and improvements. label Nov 22, 2023
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner November 22, 2023 07:15
@h0tw1r3 h0tw1r3 force-pushed the support-ed25519 branch 7 times, most recently from d0adee3 to 301c858 Compare November 22, 2023 17:37
@h0tw1r3 h0tw1r3 force-pushed the support-ed25519 branch 4 times, most recently from 210d00c to 99cee4d Compare February 13, 2024 00:01
@donoghuc
Copy link
Member

donoghuc commented May 7, 2024

@h0tw1r3 did you build a bolt package with some combo of these gems on windows? If so, could you update puppet-runtime with that corresponding change? If this builds we can certainly take this up.

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 7, 2024

I did built it, will add it to runtime and send it through the standard pipeline.

@donoghuc
Copy link
Member

donoghuc commented May 7, 2024

Thanks, yeah we will need that to be merged before we require these gems in the gemspec :)

rubygems has compiled versions of bcrypt_pbkdf 1.1.1 for windows
and now compile correctly all platforms with a supported ruby dev
environment

addresses #1987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New features and improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants