Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bolt windows ed25519 support #844

Merged
merged 2 commits into from
May 8, 2024
Merged

Bolt windows ed25519 support #844

merged 2 commits into from
May 8, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented May 7, 2024

Fixes building gems on windows x86

Blocking puppetlabs/bolt#3248

@h0tw1r3 h0tw1r3 added bug Something isn't working enhancement New feature or request labels May 7, 2024
@h0tw1r3 h0tw1r3 marked this pull request as ready for review May 7, 2024 22:58
@h0tw1r3 h0tw1r3 requested review from a team as code owners May 7, 2024 22:58
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 7, 2024

Successful Jenkins bolt-runtime build

https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging-ship-repos_generic-builder/1541/

@h0tw1r3 h0tw1r3 requested a review from donoghuc May 7, 2024 23:07
joshcooper
joshcooper approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, I ran into this with ruby 3 3e7d50b

@joshcooper joshcooper merged commit 5fdc24e into puppetlabs:master May 8, 2024
3 checks passed
@h0tw1r3 h0tw1r3 deleted the windows-ed25519 branch May 8, 2024 15:56
@donoghuc
Copy link
Member

donoghuc commented May 8, 2024

Nice, thanks

@h0tw1r3 h0tw1r3 mentioned this pull request May 17, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper approved these changes

@donoghuc donoghuc Awaiting requested review from donoghuc

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h0tw1r3 @donoghuc @joshcooper