Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncouple from the puppet_litmus gem #260

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Apr 30, 2024

Requesting feedback

Transforms this pseudo puppet module (which requires a gem not bundled with anything) into an standard r10k/bolt installable module usable outside of the litmus framework.

Module is very useful outside of litmus, particularly for real-time puppet code development. Provision a node, do some "live" development and testing, tear it down.

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 3, 2024

Related to #167

@h0tw1r3 h0tw1r3 marked this pull request as ready for review May 5, 2024 15:11
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner May 5, 2024 15:11
@jordanbreen28
Copy link
Contributor

hey @h0tw1r3 - we really like this idea. Could you look to resolve the merge conflicts, and we can start looking to move this forward.

running `rake spec` (sequential tests) or `pdk test unit -v` resulted in
none of the tests in spec/unit being run.
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Jul 9, 2024

@jordanbreen28 rebased

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Jul 9, 2024

added inventory helper spec tests

@h0tw1r3 h0tw1r3 force-pushed the uncouple branch 2 times, most recently from f149c62 to f677336 Compare July 9, 2024 08:47
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @h0tw1r3

@jordanbreen28 jordanbreen28 merged commit 775430e into puppetlabs:main Jul 9, 2024
5 of 6 checks passed
@h0tw1r3 h0tw1r3 mentioned this pull request Jul 9, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants