Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make sure that precip_models variable has the correct length #368

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

RubenImhoff
Copy link
Contributor

Fix to ensure that the _check_inputs function in /blending/steps.py looks for the correct precip_models length when a list of timesteps instead of an integer is provided.

Fix to ensure that the `_check_inputs` function in `/blending/steps.py` looks for the correct `precip_models` length when a list of timesteps instead of an integer is provided.
@RubenImhoff RubenImhoff requested a review from dnerini July 3, 2024 13:11
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (3121cbf) to head (64c8250).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   83.50%   83.82%   +0.31%     
==========================================
  Files         159      160       +1     
  Lines       12564    12788     +224     
==========================================
+ Hits        10492    10719     +227     
+ Misses       2072     2069       -3     
Flag Coverage Δ
unit_tests 83.82% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RubenImhoff RubenImhoff requested a review from ladc July 3, 2024 16:15
Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ladc
Copy link
Contributor

ladc commented Jul 9, 2024

Thanks! I haven't used custom timesteps so far, so just to check -I thought it was allowed to have non-integer timesteps if you specify custom ones, so what happens in that case? (maybe requires a ceil?)

@RubenImhoff
Copy link
Contributor Author

That is a good point, @ladc! I have not tested that (yet), but I can imagine that a ceil would solve that potential issue. Should we make sure that the number gets rounded up in that case to ensure that the non-integer timestep always falls within the total forecast length?

@dnerini
Copy link
Member

dnerini commented Jul 18, 2024

should this be added to the hackathon?

@RubenImhoff RubenImhoff merged commit 07a5aa8 into master Jul 23, 2024
10 checks passed
@dnerini dnerini deleted the RubenImhoff-fix_blending_checks branch July 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants