cuda.host_empty function #64

smazouz42 · 2024-07-10T08:22:51Z

This pull request addresses issue #56 by adding a new feature to 'cuda' host_empty that allows you to allocate memory on the CPU

This PR aims to make the C code compilable using nvcc. The cuda language was added as well as a CudaCodePrinter. Changes to stdlib: Wrapped expressions using complex types in an `ifndef __NVCC__` to avoid processing them with the nvcc compiler --------- Co-authored-by: Mouad Elalj, EmilyBourne

This pull request fixes #48, by implementing a tiny wrapper for CUDA and a wrapper for non-CUDA functionalities only with external 'C'. **Commit Summary** - Implemented new header printer for CUDA. - Added CUDA wrapper assignment - Instead of wrapping all local headers, wrap only C functions with extern 'C' --------- Co-authored-by: EmilyBourne <louise.bourne@gmail.com> Co-authored-by: bauom <40796259+bauom@users.noreply.github.com>

This pull request addresses issue #28 by implementing a new feature in Pyccel that allows users to define custom GPU kernels. The syntax for creating these kernels is inspired by Numba. and I also need to fix issue #45 for testing purposes **Commit Summary** - Introduced KernelCall class - Added cuda printer methods _print_KernelCall and _print_FunctionDef to generate the corresponding CUDA representation for both kernel calls and definitions - Added IndexedFunctionCall represents an indexed function call - Added CUDA module and cuda.synchronize() - Fixing a bug that I found in the header: it does not import the necessary header for the used function --------- Co-authored-by: EmilyBourne <louise.bourne@gmail.com> Co-authored-by: bauom <40796259+bauom@users.noreply.github.com> Co-authored-by: Emily Bourne <emily.bourne@epfl.ch>

…nctions, and refining CUDA type handling

pyccel-bot · 2024-07-10T08:23:13Z

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

EmilyBourne · 2024-07-10T08:37:05Z

pyccel/ast/cudatypes.py

+ assert isinstance(rank, int)
+ assert order in (None, 'C', 'F')


Missing assert for memory location

Probably also assert rank>0

i don't think the rank can be less than 1

Neither do I. That's why I want you to add an assert so we have an error if we write code wrong and get something with rank less than 1

pyccel/ast/cudatypes.py

EmilyBourne · 2024-07-10T08:40:13Z

pyccel/ast/cudatypes.py

+ other_f_contiguous = other.order in (None, 'F')
+ self_f_contiguous = self.order in (None, 'F')
+ order = 'F' if other_f_contiguous and self_f_contiguous else 'C'
+ return CudaArrayType(result_type, rank, order, self.memory_location)


Memory mismanagement.

from pyccel import cuda a = cuda.ones_host(4) b = cuda.ones_device(4) c = a + b # According to your function this is ok and c is on host d = b + a # According to your function this is ok and d is on device

pyccel/ast/cudatypes.py

EmilyBourne · 2024-07-10T08:45:20Z

pyccel/ast/cudatypes.py

+ if isinstance(other, FixedSizeNumericType):
+ return CudaArrayType(elem_type and other)
+ elif isinstance(other, CudaArrayType):
+ return CudaArrayType(elem_type+other.element_type)


I am not sure about this implementation. It also seems to be broken for NumPy arrays.
What is the rank/memory space?

EmilyBourne · 2024-07-10T08:45:34Z

pyccel/ast/cudatypes.py

+ this function returns None.
+ """
+ return self._order
+


Missing memory property

EmilyBourne · 2024-07-10T08:45:46Z

pyccel/ast/cudatypes.py

+ def __repr__(self):
+ dims = ','.join(':'*self._container_rank)
+ order_str = f'(order={self._order})' if self._order else ''
+ return f'{self.element_type}[{dims}]{order_str}'


Missing memory information

pyccel/ast/variable.py

smazouz42 · 2024-07-22T10:30:13Z

/bot run pr_tests

pyccel-bot

There seems to be lines in this PR which aren't tested. Please take a look at my comments and add tests which cover the new code.

If this is modified code which cannot be easily tested in this PR please open an issue to request that this code be either removed or tested. Once you have done that please leave a message on the relevant conversation beginning with the line /bot accept and referencing the issue.

Similarly if the new code cannot be tested for some reason, please leave a comment beginning with the line /bot accept on the relevant conversation explaining why the code can't be tested.

pyccel-bot · 2024-07-22T10:49:49Z

pyccel/ast/cudatypes.py

+ elif isinstance(other, CudaArrayType) or (isinstance(other, NumpyNDArrayType) and self.memory_location == "host"):
+ comparison_type = np.zeros(1, dtype = pyccel_type_to_original_type[other.element_type])
+ else:
+ return NotImplemented


This code isn't tested. Please can you take a look

/bot accept
The fallback return NotImplemented does not need testing

pyccel/ast/cudatypes.py

pyccel-bot · 2024-07-22T10:49:50Z

pyccel/codegen/printing/cucode.py

+ return f"cuda_free({var_code});\n"
+


This code isn't tested. Please can you take a look

/bot accept
the free of the device array will be tested in the next PRs

smazouz42 · 2024-07-22T10:57:24Z

/bot run pyccel_lint

smazouz42 · 2024-07-22T11:00:20Z

/bot run pr_tests

pyccel-bot

There seems to be lines in this PR which aren't tested. Please take a look at my comments and add tests which cover the new code.

If this is modified code which cannot be easily tested in this PR please open an issue to request that this code be either removed or tested. Once you have done that please leave a message on the relevant conversation beginning with the line /bot accept and referencing the issue.

Similarly if the new code cannot be tested for some reason, please leave a comment beginning with the line /bot accept on the relevant conversation explaining why the code can't be tested.

smazouz42 · 2024-07-22T13:56:31Z

/bot run pr_tests

pyccel-bot

There seems to be lines in this PR which aren't tested. Please take a look at my comments and add tests which cover the new code.

If this is modified code which cannot be easily tested in this PR please open an issue to request that this code be either removed or tested. Once you have done that please leave a message on the relevant conversation beginning with the line /bot accept and referencing the issue.

Similarly if the new code cannot be tested for some reason, please leave a comment beginning with the line /bot accept on the relevant conversation explaining why the code can't be tested.

pyccel-bot · 2024-07-22T14:50:17Z

I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using /bot checklist.

pyccel-bot · 2024-07-22T14:52:56Z

I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using /bot checklist.

smazouz42 · 2024-07-22T14:55:03Z

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

Write a clear PR description
Add tests to check your code works as expected
Update documentation if necessary
Update Changelog
Ensure any relevant issues are linked
Ensure new tests are passing

pyccel-bot · 2024-07-22T14:55:58Z

I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using /bot checklist.

smazouz42 · 2024-07-22T14:56:39Z

/bot run pr_tests

pyccel-bot · 2024-07-22T14:57:30Z

I can't seem to find your checklist to confirm that you have completed all necessary tasks. Please request one using /bot checklist.

pyccel-bot

Good job ! Your PR is using all the code it added/changed.

pyccel-bot

Good job ! Your PR is using all the code it added/changed.

EmilyBourne and others added 15 commits June 27, 2024 08:10

Trigger tests on push to devel or main branch

c7a6638

Add cuda workflow to test cuda developments on CI

821a1c5

Trigger tests on push to devel or main branch

092b557

Begin implementation of CUDA arrays: adding cudaempty and cudafull fu…

80f905b

…nctions, and refining CUDA type handling

work in progress

7e8cf9e

work in progress

2dbcfae

work in progress

f3911d5

work in progress

37289f9

work in progress

ba66b48

work in progress

406a88b

work in progress

3afad1b

work in progress

190c5a2

github-actions bot marked this pull request as draft July 10, 2024 08:23

smazouz42 added 2 commits July 10, 2024 09:25

cleaning up my PR

eeeb249

cleaning up my PR

de0f5ab

smazouz42 changed the title ~~Add Python code to spoof a host_empty function~~ cuda.host_empty function Jul 10, 2024