Add light-weight MLP #372
Merged
Add light-weight MLP #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 93.45% 93.52% +0.06%
==========================================
Files 122 124 +2
Lines 6401 6451 +50
==========================================
+ Hits 5982 6033 +51
+ Misses 419 418 -1 ☔ View full report in Codecov by Sentry. |
yiweny
approved these changes
Mar 7, 2024
rusty1s
reviewed
Mar 10, 2024
| ) | ||
|
|
||
| self.mlp = Sequential() | ||
| norm_cls = LayerNorm if normalization == "layernorm" else BatchNorm1d |
There was a problem hiding this comment.
You don't respect no normalization here.
Comment on lines
+97
to
+98
| if (isinstance(param, Linear) or isinstance(param, BatchNorm1d) | ||
| or isinstance(param, LayerNorm)): |
There was a problem hiding this comment.
if hasattr(self, 'reset_parameters'):
| channels (int): The number of channels in the backbone layers. | ||
| out_channels (int): The number of output channels in the decoder. | ||
| num_layers (int): The number of layers in the backbone. | ||
| col_stats(dict[str,Dict[:class:`torch_frame.data.stats.StatType`,Any]]): |
weihua916
added a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.