-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qhc 684 implement distortions in qprogram #779
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 273 273
Lines 9025 9030 +5
=======================================
+ Hits 8650 8655 +5
Misses 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Requesting permission from @jjmartinezQT to launch a new realease from qpysequence and fix the test error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! I like the simplicity. We should add tests to verify that the waveforms are modified indeed based on the distortion provided. E.g. play the same waveform to two buses, one without distortions and the other with, and check that the first one the pulse is umodified and the second one is.
…ithub.com/qilimanjaro-tech/qililab into qhc-684-implement-distortions-in-qprogram
…ithub.com/qilimanjaro-tech/qililab into qhc-684-implement-distortions-in-qprogram
I added the tests including some qpysequence changes to make it more consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💯 I requested changes mainly because of the test.
Co-authored-by: Vyron Vasileiadis <hi@fedonman.com>
Co-authored-by: Vyron Vasileiadis <hi@fedonman.com>
…ithub.com/qilimanjaro-tech/qililab into qhc-684-implement-distortions-in-qprogram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 💯
Created a section on platform execute_qprogram_qblox to define the waveform distortions based on pulse_distortions