Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qhc 684 implement distortions in qprogram #779

Merged
merged 52 commits into from
Sep 23, 2024

Conversation

jordivallsq
Copy link
Contributor

Created a section on platform execute_qprogram_qblox to define the waveform distortions based on pulse_distortions

Copy link

linear bot commented Aug 19, 2024

@jordivallsq jordivallsq self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (c10e5b0) to head (5887616).
Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         273      273           
  Lines        9025     9030    +5     
=======================================
+ Hits         8650     8655    +5     
  Misses        375      375           
Flag Coverage Δ
unittests 95.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordivallsq
Copy link
Contributor Author

Requesting permission from @jjmartinezQT to launch a new realease from qpysequence and fix the test error

Copy link
Collaborator

@fedonman fedonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! I like the simplicity. We should add tests to verify that the waveforms are modified indeed based on the distortion provided. E.g. play the same waveform to two buses, one without distortions and the other with, and check that the first one the pulse is umodified and the second one is.

@jordivallsq
Copy link
Contributor Author

Awesome job! I like the simplicity. We should add tests to verify that the waveforms are modified indeed based on the distortion provided. E.g. play the same waveform to two buses, one without distortions and the other with, and check that the first one the pulse is umodified and the second one is.

I added the tests including some qpysequence changes to make it more consistent

@jordivallsq jordivallsq requested a review from fedonman September 6, 2024 15:40
Copy link
Collaborator

@fedonman fedonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯 I requested changes mainly because of the test.

src/qililab/platform/platform.py Outdated Show resolved Hide resolved
src/qililab/platform/platform.py Outdated Show resolved Hide resolved
tests/platform/test_platform.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fedonman fedonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯

@jordivallsq jordivallsq merged commit a0ee1d5 into main Sep 23, 2024
6 checks passed
@jordivallsq jordivallsq deleted the qhc-684-implement-distortions-in-qprogram branch September 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants