Qhc 684 implement distortions in qprogram

docs/releases/changelog-dev.md

@@ -4,6 +4,35 @@
 
 ### Improvements
 
+- Added pulse distorsions in `execute_qprogram` for QBlox in a similar methodology to the distorsions implemented in pulse circuits. The runcard needs to contain the same structure for distorsions as the runcards for circuits and the code will modify the waveforms after compilation (inside `platform.execute_qprogram`).
+
+  Example (for Qblox)
+
+  ```
+  buses:
+  - alias: readout
+    ...
+    distortions: 
+      - name: exponential
+        tau_exponential: 1.
+        amp: 1.
+        sampling_rate: 1.  # Optional. Defaults to 1
+        norm_factor: 1.  # Optional. Defaults to 1
+        auto_norm: True  # Optional. Defaults to True
+      - name: bias_tee
+        tau_bias_tee: 11000
+        sampling_rate: 1.  # Optional. Defaults to 1
+        norm_factor: 1.  # Optional. Defaults to 1
+        auto_norm: True  # Optional. Defaults to True
+      - name: lfilter
+        a: []
+        b: []
+        norm_factor: 1.  # Optional. Defaults to 1
+        auto_norm: True  # Optional. Defaults to True
+  ```
+
+  [#779](https://github.com/qilimanjaro-tech/qililab/pull/779)
+
 ### Breaking changes
 
 ### Deprecations / Removals

requirements.txt

@@ -6,7 +6,7 @@ qcodes_contrib_drivers==0.18.0
 PyVISA-py==0.7.1
 tqdm==4.64.1
 urllib3==1.26.12
-qpysequence==0.10.1
+qpysequence==0.10.4
 h5py==3.11.0
 papermill==2.4.0
 qm-qua==1.2.0

src/qililab/platform/platform.py

@@ -860,7 +860,13 @@ def _execute_qprogram_with_qblox(  # pylint: disable=too-many-locals
             markers=markers,
         )
         buses = {bus_alias: self._get_bus_by_alias(alias=bus_alias) for bus_alias in sequences}
-
+        for bus_alias, bus in buses.items():
+            if bus.distortions:
+                for distortion in bus.distortions:
+                    for waveform in sequences[bus_alias]._waveforms._waveforms:  # pylint: disable=protected-access
+                        sequences[bus_alias]._waveforms.modify(  # pylint: disable=protected-access
+                            waveform.name, distortion.apply(waveform.data)
+                        )
         if debug:
             with open("debug_qblox_execution.txt", "w", encoding="utf-8") as sourceFile:
                 for bus_alias in sequences:

src/qililab/qprogram/qblox_compiler.py

@@ -271,7 +271,7 @@ def handle_waveform(waveform: Waveform | None, default_length: int = 0):
         return index_I, index_Q, length_I
 
     def _append_to_weights_of_bus(self, bus: str, weights: IQPair):
-        def handle_waveform(waveform: Waveform):
+        def handle_weight(waveform: Waveform):
             _hash = QbloxCompiler._hash_waveform(waveform)
 
             if _hash in self._buses[bus].weight_to_index:
@@ -289,8 +289,8 @@ def handle_waveform(waveform: Waveform):
             self._buses[bus].weight_to_index[_hash] = index
             return index, length
 
-        index_I, length_I = handle_waveform(weights.I)
-        index_Q, _ = handle_waveform(weights.Q)
+        index_I, length_I = handle_weight(weights.I)
+        index_Q, _ = handle_weight(weights.Q)
         return index_I, index_Q, length_I
 
     def _handle_parallel(self, element: Parallel):

tests/data.py

@@ -713,7 +713,9 @@ class Galadriel:
                 RUNCARD.INSTRUMENTS: [InstrumentName.QBLOX_QCM.value, "rs_0"],
             },
             "port": "drive_q0",
-            RUNCARD.DISTORTIONS: [],
+            RUNCARD.DISTORTIONS: [
+                {"name": "lfilter", "a": [1.0, 0.0, 1.0], "auto_norm": True, "b": [0.5, 0.5], "norm_factor": 1.0}
+            ],
             RUNCARD.DELAY: 0,
         },
         {

tests/platform/test_platform.py

@@ -13,7 +13,7 @@
 from qibo import gates
 from qibo.models import Circuit
 from qm.exceptions import StreamProcessingDataLossError
-from qpysequence import Sequence
+from qpysequence import Sequence, Waveforms
 from ruamel.yaml import YAML
 
 from qililab import Arbitrary, save_platform
@@ -655,6 +655,26 @@ def test_execute_qprogram_with_qblox(self, platform: Platform):
         # assure only one debug was called
         assert patched_open.call_count == 1
 
+    def test_execute_qprogram_with_qblox_distortions(self, platform: Platform):
+        drive_wf = Square(amplitude=1.0, duration=4)
+        qprogram = QProgram()
+        qprogram.play(bus="drive_line_q0_bus", waveform=drive_wf)
+
+        test_waveforms_q0 = Waveforms()
+        test_waveforms_q0.add(array=[0.5, 1.0, 0.5, 0.0], index=0)
+        test_waveforms_q0.add(array=[0.0, 0.0, 0.0, 0.0], index=1)
+
+        with (
+            patch("builtins.open"),
+            patch.object(Bus, "upload_qpysequence") as upload,
+            patch.object(Bus, "run"),
+            patch.object(Bus, "acquire_qprogram_results"),
+            patch.object(QbloxModule, "sync_by_port"),
+            patch.object(QbloxModule, "desync_by_port"),
+        ):
+            _ = platform.execute_qprogram(qprogram=qprogram)
+            assert test_waveforms_q0.to_dict() == upload.call_args_list[0].kwargs["qpysequence"]._waveforms.to_dict()
+
     def test_execute_qprogram_with_quantum_machines(
         self, platform_quantum_machines: Platform
     ):  # pylint: disable=too-many-locals