Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-833] Make optimization of Drag gates #863

Open
wants to merge 10 commits into
base: solving-transpilation
Choose a base branch
from

Conversation

GuillermoAbadLopez
Copy link
Contributor

@GuillermoAbadLopez GuillermoAbadLopez commented Dec 28, 2024

TODOs in this PR:

  • Make bunching of consecutive Drag Gates (fill bunch_drag_gates(...))
  • Make the deletion of gates with no amplitude (fill delete_gates_with_no_amplitude(...))
  • Make tests to cover this, and manually check it works!

And next PRs:

Solve more buggs about final layout/compute it yourself? 🔥🔥🔥

  • Check if Update qibo version solves it?
  • Mirar reported layout para el caso que no cambia
  • Make that reported layout works always

Improve readability of layout 🔥🔥🔥:

  • Make more clear what are keys/values in the dict
  • State clearly the final ordering of qubits (@Ameer)
  • Maybe log both init_layout (placement) & final_layout (placement+routing)

Copy link

linear bot commented Dec 28, 2024

@GuillermoAbadLopez GuillermoAbadLopez self-assigned this Dec 28, 2024
Copy link

🔗Pullpo.io Slack channel

Copy link

pullpo-for-slack bot commented Dec 28, 2024

AI Analysis

Review:

The addition of TODO comments in the code to implement bunching of Drag gates and deletion of Drag gates without amplitude is a good practice for future development. It shows that there is a plan to improve the codebase further and maintain its efficiency. Make sure to revisit these TODOs to implement the functionality at a later stage.

Detailed file changes

(dropdown):

In circuit_optimizer.py:

  • Added TODO to add bunching of Drag gates.
  • Added TODO to add deletion of Drag gates without amplitude.

@GuillermoAbadLopez GuillermoAbadLopez changed the title [QHC-833] Update circuit_optimizer.py [QHC-833] Make optimization of Drag gates Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.77%. Comparing base (7fb7339) to head (0592118).

Files with missing lines Patch % Lines
src/qililab/digital/circuit_optimizer.py 96.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           solving-transpilation     #863      +/-   ##
=========================================================
- Coverage                  96.78%   96.77%   -0.01%     
=========================================================
  Files                        221      221              
  Lines                       7765     7811      +46     
=========================================================
+ Hits                        7515     7559      +44     
- Misses                       250      252       +2     
Flag Coverage Δ
unittests 96.77% <96.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant