Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-845] Follow up on Drag Bunching #868

Draft
wants to merge 8 commits into
base: adding_optimize_transpiled_gates
Choose a base branch
from

Conversation

GuillermoAbadLopez
Copy link
Contributor

@GuillermoAbadLopez GuillermoAbadLopez commented Jan 14, 2025

TODOs in this PR:

  • Make bunching of consecutive Drag Gates if phis diff! (fill bunch_drag_gates(... only_same_phi=False))
  • Cover changes with tests.

Copy link

linear bot commented Jan 14, 2025

Copy link

🔗Pullpo.io Slack channel

Copy link

pullpo-for-slack bot commented Jan 14, 2025

AI Analysis

Review:

The removal of the TODO comment suggests that the task related to adding bunching drag gates for different phi's has been completed or deemed unnecessary. Changing the parameter only_same_phi to False in the function call may indicate a functional enhancement or a modification in the behavior of the bunch_drag_gates function. Overall, the changes seem to be straightforward and related to improving the functionality of the code.

Detailed file changes

(dropdown):

In circuit_optimizer.py:

  • Removed a TODO comment related to adding bunching drag gates for different phi's.
  • Changed the parameter only_same_phi to False in the bunch_drag_gates function call.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (6569a0e) to head (915717c).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           adding_optimize_transpiled_gates     #868      +/-   ##
====================================================================
- Coverage                             97.32%   97.32%   -0.01%     
====================================================================
  Files                                   231      231              
  Lines                                  8340     8333       -7     
====================================================================
- Hits                                   8117     8110       -7     
  Misses                                  223      223              
Flag Coverage Δ
unittests 97.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuillermoAbadLopez GuillermoAbadLopez marked this pull request as draft January 14, 2025 11:05
@GuillermoAbadLopez GuillermoAbadLopez self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant