Change @classmethods to @staticmethods

[GuillermoAbadLopez]

No description provided.

[pullpo-for-slack]

🔗Pullpo.io Slack channel

[pullpo-for-slack]

AI Analysis

Review:

Overall, the changes made in the code involve converting class methods to static methods, adding missing import statements, and fixing formatting issues. The conversion to static methods seems appropriate based on the provided information and can help in improving code clarity and reusability. The corrections made indicate a focus on improving code quality and maintainability. Great job on these enhancements!

Detailed file changes

(dropdown):

In circuit_optimizer.py:

• In circuit_optimizer.py: The optimize_gates and cancel_pairs_of_hermitian_gates methods were changed from classmethod to staticmethod.
• In circuit_optimizer.py: Methods bunch_drag_gates, normalize_angles_of_drags, and delete_gates_with_no_amplitude were changed from classmethod to staticmethod.

In qblox_acquisitions_builder.py:

• Updated the class method decorators to staticmethod for 'get_scope', 'get_bins', and '_get_sequencer_with_scope_data_available'.
• Changed the class references to 'QbloxAcquisitionsBuilder' in 'get_scope' and '_get_sequencer_with_scope_data_available' methods.

In pulse_distortion.py:

• Added missing import statement for 'np'.
• Updated the class method decorator to staticmethod for 'from_dict'.
• Fixed indentation issue in the example code block.
• Corrected the formatting of the example code block.

In circuit_router.py:

• Updated the class method decorators to staticmethod for '_build_router'.
• Changed the class references to 'CircuitRouter' in '_highest_degree_node' method.

In bias_tee_correction.py:

• Added missing import statement for 'np'.
• Updated the class method decorator to staticmethod for 'from_dict'.
• Corrected the return statement in 'from_dict' method.

In lfilter_correction.py:

• Changed the class method from_dict to a static method.
• Modified the return statement in the static method from_dict.

In pulse_event.py:

• Changed the class method from_dict to a static method.
• Modified the return statement in the static method from_dict.

In flat_top.py:

• Changed the class method from_dict to a static method.
• Modified the return statement in the static method from_dict.

In rectangular.py:

• Changed the class method from_dict to a static method.
• Modified the return statement in the static method from_dict.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (0a1efab) to head (1f15cd8).
Report is 1 commits behind head on adding_optimize_transpiled_gates.

Additional details and impacted files

@@                        Coverage Diff                        @@
##           adding_optimize_transpiled_gates     #870   +/-   ##
=================================================================
  Coverage                             97.32%   97.32%           
=================================================================
  Files                                   231      231           
  Lines                                  8338     8338           
=================================================================
  Hits                                   8115     8115           
  Misses                                  223      223           

Flag	Coverage Δ
unittests	97.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.