Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CL in ConfigRecorder #44534

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Check CL in ConfigRecorder #44534

merged 1 commit into from
Nov 16, 2024

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Nov 15, 2024 •
edited
Loading

To detect possible issues with failures in OverrideBuildTimeConfigTest, observed in:

@quarkusio quarkusio deleted a comment from quarkus-bot bot Nov 15, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 16, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8a15454.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gsmet
gsmet approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge it but we need to make sure this code doesn't end up in a release.

@gsmet gsmet merged commit dfbc709 into quarkusio:main Nov 16, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 16, 2024
@radcortez radcortez mentioned this pull request Nov 18, 2024
Merged
@gsmet gsmet removed this from the 3.18 - main milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/config area/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radcortez @gsmet