use = instead of <- + prefix sf:: in code
#893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of `T`, `FALSE` instead of `F`
olivroy
changed the title
= instead of <- + prefix sf:: in code
olivroy
changed the title
= instead of <- + prefix sf:: in code= instead of <- + prefix sf:: in code
olivroy
commented
Jun 26, 2024
|
@mtennekes Are you okay with merging this. Thanks for pushing changes. With your latest changes, this PR is essentially just cosmetic fixes (namespacing, |
olivroy
changed the title
= instead of <- + prefix sf:: in code= instead of <- + prefix sf:: in code
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks so much for getting to it! Seems to work fine to me :) Will test more extensively once this PR is merged.
Followup to fix #851. taken care of in 7353784Add information to
NEWSabout the "Breaking" changeTo simplify things, I added a R 3.6 dep. (Some base pipe
|>is used in tmap v4, so the actual dep is R 4.1) tmap doesn't test this version and it makes it easier to register methodsSilence note about methods in Depends by moving to Imports.
Update documentation with
check_man()I added more commits to prefix
sf::calls and to replace<-with=in the codebase.