Verify correct behaviour when adding empty nodes recorded from an in-order queue #239
Labels
Comments
EwanC
added
bug
mfrancepillois
added a commit
that referenced
this issue
Jul 5, 2023
Adding a empty node to a recorded in-order queue resulted in inconsistent dependencies between nodes. This patch fixes this issues and simplifies the adding of empty nodes. Unitests have been added to check node dependencies when recording an in_order queue with and without empty nodes. Fixes Issue: #239
mfrancepillois
added a commit
that referenced
this issue
Jul 5, 2023
Adding a empty node to a recorded in-order queue resulted in inconsistent dependencies between nodes. This patch fixes this issues and simplifies the adding of empty nodes. Unitests have been added to check node dependencies when recording an in_order queue with and without empty nodes. Fixes Issue: #239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have tests for using empty nodes and in-order queues separately with record & replay graph construction, but don't test that both work together. We should add a test to verify this and fix any bugs that are required for it to pass.
See #237 (comment) for motivation
Existing in-order tests:
sycl/test-e2e/Graph/RecordReplay/dotp_in_order.cppsycl/test-e2e/Graph/RecordReplay/subgraph_in_order.cppsycl/test-e2e/Graph/RecordReplay/usm_copy_in_order.cppExisting empty node tests:
sycl/test-e2e/Graph/RecordReplay/empty.cpp/sycl/test-e2e/Graph/RecordReplay/empty_node_with_dep.cppThe text was updated successfully, but these errors were encountered: