Fix adding empty nodes to the graph results in two root nodes #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bensuo
approved these changes
Jun 22, 2023
Bensuo
added
the
Graph Implementation
EwanC
approved these changes
Jun 26, 2023
| auto EventImpl = std::make_shared<detail::event_impl>(); | ||
|
|
||
| // Extract relevant data from the handler and pass to graph to create a | ||
| // new node representing this command group. | ||
| std::shared_ptr<ext::oneapi::experimental::detail::node_impl> NodeImpl = | ||
| GraphImpl->add(CGData.MEvents); | ||
| QueueGraph->add(CGData.MEvents); |
There was a problem hiding this comment.
Reviewing this code, I'm wondering if empty nodes will work with in-order queues for record & replay because we don't reach the code on lines 428-443.
Created #239 to investigate this, as it shouldn't hold up this PR
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
EwanC
pushed a commit
that referenced
this pull request
Jun 29, 2023
Fix adding empty nodes to the graph results in two root nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue revealed in
CommandGraphTest.AddNodewhere an empty node without dependencies would lead to two root nodes being added to the graph. The first is added in the special Graph case inhandler::finalize()and the second ingraph_impl::add(const std::vector<std::shared_ptr<node_impl>> &Dep). This patch adds a node inhandler::finalize()only during queue recording. Explicitly added empty nodes use a new command group with none-type and follow the regular kernelgraph_impl::addpath.isEmpty()is extended to include command groups with none-type.This supersedes #236 which lacked support for record and replay mode.