[SYCL][Graph] command_graph queue constructor #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
added
Graph Specification
EwanC
force-pushed
the
queue_constructor
branch
from
136ac5a
to
d45f896
Compare
Bensuo
approved these changes
Jan 8, 2024
Feedback from Jack Kirk (@JackAKirk) that SYCL classes with a sycl::context and sycl::device constructor normally have a matching constructor taking a sycl::queue which replaces the context and device. Being able to use a queue constructor makes it easier to port code from CUDA/HIP where there is not a concept analogous to SYCL contexts. Our tests/examples also commonly use the pattern ```cpp queue Queue; command_graph Graph {Queue.get_context(), Queue.get_device()} ``` So being able to use a queue constructor is also a more concise way to call the constructor in a lot of cases, regardless of platform.
EwanC
force-pushed
the
queue_constructor
branch
from
d45f896
to
7b2101f
Compare
|
Moved to an upstream PR intel#12330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from @JackAKirk that SYCL classes with a sycl::context and sycl::device constructor normally have a matching constructor taking a sycl::queue which replaces the context and device.
Being able to use a queue constructor makes it easier to port code from CUDA/HIP where there is not a concept analogous to SYCL contexts.
Our tests/examples also commonly use the pattern
queue Queue; command_graph Graph {Queue.get_context(), Queue.get_device()}So being able to use a queue constructor is also a more concise way to call the constructor in a lot of cases, regardless of platform.