Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] command_graph queue constructor #349

Closed
wants to merge 1 commit into from
Closed

Commits on Jan 8, 2024

  1. [SYCL][Graph] command_graph queue constructor

    Feedback from Jack Kirk (@JackAKirk) that SYCL classes with a sycl::context
    and sycl::device constructor normally have a matching constructor
    taking a sycl::queue which replaces the context and device.
    
    Being able to use a queue constructor makes it easier to port code from
    CUDA/HIP where there is not a concept analogous to SYCL contexts.
    
    Our tests/examples also commonly use the pattern
    ```cpp
    queue Queue;
    command_graph Graph {Queue.get_context(), Queue.get_device()}
    ```
    
    So being able to use a queue constructor is also a more concise way
    to call the constructor in a lot of cases, regardless of platform.
    EwanC committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7b2101f View commit details
    Browse the repository at this point in the history