Migrate to reconciler.io/runtime #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping as draft in case we find a more graceful way to transition the repo. |
scothis
commented
Mar 11, 2024
| `reconciler-runtime` was conceived in [`projectriff/system`](https://github.com/projectriff/system/) and implemented initially by [Scott Andrews](https://github.com/scothis), [Glyn Normington](https://github.com/glyn) and the [riff community](https://github.com/orgs/projectriff/people) at large, drawing inspiration from [Kubebuilder](https://www.kubebuilder.io) and [Knative](https://knative.dev) reconcilers. | ||
| `reconciler-runtime` was conceived at VMware within [`projectriff/system`](https://github.com/projectriff/system/) and implemented initially by [Scott Andrews](https://github.com/scothis), [Glyn Normington](https://github.com/glyn) and the [riff community](https://github.com/orgs/projectriff/people) at large, drawing inspiration from [Kubebuilder](https://www.kubebuilder.io) and [Knative](https://knative.dev) reconcilers. | ||
|
|
||
| All commits before (TODO this one) are copyright VMware and consumed under the Apache License v2.0, unless otherwise marked. After this point all commits are copyright of the respective author and licensed to the community under the Apache License v2.0, via a [Developer Certificate of Origin (DCO)](https://developercertificate.org). |
There was a problem hiding this comment.
TODO - need the final gitsha/date. Will follow up after merge.
Previously, the ChildSetReconciler would list children once for the set and again for each child being reconciled. At best this was inefficient, at worst it introduced subtile issues when the content of the listing changed over the course of the reconcile. Now the content of the list from the ChildSetReconciler is reused by each child that is reconciled. Signed-off-by: Scott Andrews <scott@andrews.me>
This is a major breaking change that will require users to actively
update their usage of reconciler-runtime. Existing package imports with
the prefix github.com/vmware-labs/reconciler-runtime need to be updated
to reconciler.io/runtime.
Before:
import "github.com/vmware-labs/reconciler-runtime/reconcilers"
After:
import "reconciler.io/runtime/reconcilers"
There are no other API changes.
Signed-off-by: Scott Andrews <scott@andrews.me>
mamachanko
reviewed
Mar 12, 2024
| * Max Brauer, [mamachanko](https://github.com/mamachanko) | ||
|
|
||
| # Emeritus maintainers | ||
|
|
||
| * Scott Andrews, [scothis](https://github.com/scothis) |
mamachanko
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major breaking change that will require users to actively update their usage of reconciler-runtime. Existing package imports with the prefix github.com/vmware-labs/reconciler-runtime need to be updated to reconciler.io/runtime.
Before:
After:
There are no other API changes.