Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to reconciler.io/runtime #1

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Migrate to reconciler.io/runtime #1

merged 2 commits into from
Mar 13, 2024

Commits on Mar 11, 2024

  1. List children exactly once for ChildSetReconciler (#494) 

    Previously, the ChildSetReconciler would list children once for the
set and again for each child being reconciled. At best this was
inefficient, at worst it introduced subtile issues when the content of
the listing changed over the course of the reconcile.

Now the content of the list from the ChildSetReconciler is reused by
each child that is reconciled.

Signed-off-by: Scott Andrews <scott@andrews.me>
    @scothis
    scothis authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7342347 View commit details
    Browse the repository at this point in the history

  2. Migrate to reconciler.io/runtime 

    This is a major breaking change that will require users to actively
update their usage of reconciler-runtime. Existing package imports with
the prefix github.com/vmware-labs/reconciler-runtime need to be updated
to reconciler.io/runtime.

Before:

    import "github.com/vmware-labs/reconciler-runtime/reconcilers"

After:

    import "reconciler.io/runtime/reconcilers"

There are no other API changes.

Signed-off-by: Scott Andrews <scott@andrews.me>
    @scothis
    scothis committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2ce2d17 View commit details
    Browse the repository at this point in the history