Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): rename class creator allowlist messages #1463

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Sep 2, 2022

Description

Ref: #1387

This pull request updates the names of messages for the class creator allowlist. The use of "registries" will be considered when we add registries as on-chain entities. No functionality was changed in this pull request, simply naming and ordering. Also added the missing grpc integration test for querying the class creator allowlist setting.

  • Use "set" instead of "toggle" as "toggle" implies it will be toggled to the value it is not currently set to.
  • Use "class creator allowlist" instead of "credit class allowlist enabled" to clarify and prevent redundancy as we are in the "ecocredit" module and do not use "credit" for anything other than "credit type" at the moment and "enabled" is a property returned in the "class creator allowlist" response.

All proto-breaking changes are part of the current revision and therefore no API breaking changes for the v1 package.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1463 (2df0df0) into main (6d96e5f) will increase coverage by 0.01%.
The diff coverage is 81.39%.

@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
+ Coverage   78.37%   78.38%   +0.01%     
==========================================
  Files         238      238              
  Lines       18494    18505      +11     
==========================================
+ Hits        14495    14506      +11     
  Misses       3154     3154              
  Partials      845      845              
Impacted Files Coverage Δ
x/ecocredit/client/query.go 0.00% <0.00%> (ø)
...t/base/types/v1/msg_set_class_creator_allowlist.go 41.66% <20.00%> (ø)
...redit/base/keeper/query_class_creator_allowlist.go 62.50% <62.50%> (ø)
x/ecocredit/base/client/query.go 68.95% <100.00%> (ø)
x/ecocredit/base/keeper/msg_create_class.go 68.42% <100.00%> (ø)
...dit/base/keeper/msg_set_class_creator_allowlist.go 70.00% <100.00%> (ø)
x/ecocredit/base/keeper/query_params.go 55.73% <100.00%> (ø)
x/ecocredit/client/testsuite/grpc.go 100.00% <100.00%> (ø)
x/ecocredit/client/testsuite/query.go 99.52% <100.00%> (ø)
x/ecocredit/client/testsuite/suite.go 96.48% <100.00%> (ø)
... and 1 more

@ryanchristo ryanchristo marked this pull request as ready for review September 2, 2022 01:45
@ryanchristo ryanchristo requested a review from a team September 2, 2022 01:45
@ryanchristo
Copy link
Member Author

Opened #1464 as a followup. The updates in this pull request for the state message and the query would be the state message and query of the credit class creator allowlist but we would add the list of credit class creators to the state message and query.

@ryanchristo ryanchristo merged commit c39d0f4 into main Sep 2, 2022
@ryanchristo ryanchristo deleted the ryan/1387-class-creator-allowlist branch September 2, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants