fix(bitbucket): source link root path #32689
Open
+36
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
viceice
requested changes
Nov 23, 2024
| @@ -1,6 +1,7 @@ | |||
| import type { RenovateConfig } from '../../../../../config/types'; | |||
| import type { PrDebugData } from '../../../../../modules/platform'; | |||
| import { platform } from '../../../../../modules/platform'; | |||
| import { BITBUCKET_WEB_ENDPOINT } from '../../../../../modules/platform/bitbucket'; | |||
There was a problem hiding this comment.
export a new optional platform API instead, we don't want to have deep import from platforms here.
There was a problem hiding this comment.
I dont think that will work since its not the renovate platform, but the specific update platform/host that I need to check
eg: renovate running on a GitHub repository with an update for a Bitbucket-hosted package
is there another way to achieve this? essentially I want to check the updates host type (bitbucket, github, etc)
Signed-off-by: Adam Setch <adam.setch@outlook.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Source URL path for Bitbucket Cloud is
src/nottree/Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: