fix: test runner cannot find element when wrapped with another element #2154
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
requested review from
tomiir and
svenvoskamp
and removed request for
tomiir
enesozturk
changed the title
apps/laboratory/package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "playwright:test:email": "playwright test --grep 'email.spec.ts'", | |||
| "playwright:test:siwe": "playwright test --grep siwe.spec.ts", | |||
| "playwright:test:sa": "playwright test --grep smart-account.spec.ts", | |||
| "playwright:test:canary": "playwright test --retries=0 --grep canary.spec.ts --project='Desktop Chrome/wagmi'", | |||
| "playwright:test:canary": "playwright test --retries=0 --grep canary.spec.ts --project='Desktop Firefox/ethers'", | |||
There was a problem hiding this comment.
Why are you switching this?
There was a problem hiding this comment.
This was for local testing purpose, should have been missed. Will revert back.
There was a problem hiding this comment.
Btw, why it's testing only on wagmi?
There was a problem hiding this comment.
Because the canary is supposed to test if the system is generally working together. E.g. is the relay down, and what is the overall latency of the system over-time. Chromium/Wagmi is the sort of best-case configuration/recommendation and is least likely to fail from test flakes
| @@ -95,6 +95,7 @@ jobs: | |||
| - name: Run canary with minimal environment config | |||
| env: | |||
| NEXT_PUBLIC_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_PROJECT_ID }} | |||
| MAILSAC_API_KEY: ${{ secrets.TESTS_MAILSEC_API_KEY }} | |||
There was a problem hiding this comment.
The whole point of this minimal environment step is to have a minimum configuration. The canary doesn't need this API key and isn't available when the canary is run automatically. So it shouldn't be passed here to ensure the canary works without it.
There was a problem hiding this comment.
I see. Then I think we should remove the requirement of using w3m-email-fixture.ts which is checking MAILSAC_API_KEY and causing tests to fail. Example
I think this is a matter of the PR we introduced minimal test step. I'll take a look how we could do this.
There was a problem hiding this comment.
Is the canary now running new tests? Why was it working before and not anymore?
There was a problem hiding this comment.
The canary has been working, you can see it at the bottom of this Grafana dashboard. Doesn't seem like #2029 affected it
| @@ -95,6 +95,7 @@ jobs: | |||
| - name: Run canary with minimal environment config | |||
There was a problem hiding this comment.
| - name: Run canary with minimal environment config | |
| - name: Run canary with minimal environment config | |
| # Keep in-sync with https://github.com/WalletConnect/rs-relay/blob/master/terraform/canary/main.tf#L48 |
Issue
The Playwright tests are unable to find the element when another DOM element is on top of the queried element. This causes tests to not proceed and fail.
Changes
This PR was introduced to replace the toast components which is rendering the toast at the right-bottom of the screen. These changes are already introduced in #2102 but to be able to fix the test issues first, toast replacement is separated to be sure they are running as expected.
Additional
We are also missing the
MAILSAC_API_KEYfor the ui-testsRun canary with minimal environment configstep.