-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test runner cannot find element when wrapped with another element #2154
Changes from all commits
4339257
b65d7c0
7f2b234
2ed1255
02e0871
73252b0
c5319cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,6 +95,7 @@ jobs: | |
- name: Run canary with minimal environment config | ||
env: | ||
NEXT_PUBLIC_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_PROJECT_ID }} | ||
MAILSAC_API_KEY: ${{ secrets.TESTS_MAILSEC_API_KEY }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The whole point of this minimal environment step is to have a minimum configuration. The canary doesn't need this API key and isn't available when the canary is run automatically. So it shouldn't be passed here to ensure the canary works without it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see. Then I think we should remove the requirement of using I think this is a matter of the PR we introduced minimal test step. I'll take a look how we could do this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the canary now running new tests? Why was it working before and not anymore? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The canary has been working, you can see it at the bottom of this Grafana dashboard. Doesn't seem like #2029 affected it |
||
CI: true | ||
working-directory: ./apps/laboratory/ | ||
run: npm run playwright:test:canary | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.