Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: When re-scanning don't reset disk selection #5078

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

KKoukiou
Copy link
Contributor

Instead keep selected disks if they are still usable.

Relevant to https://bugzilla.redhat.com/show_bug.cgi?id=2231357#c3

@KKoukiou
Copy link
Contributor Author

This needs some tests adjustments. Feel free to take over it if it needs to be in within the next 2 weeks that I am on PTO.

@rvykydal
Copy link
Contributor

rvykydal commented Sep 4, 2023

This needs some tests adjustments. Feel free to take over it if it needs to be in within the next 2 weeks that I am on PTO.

I am making some of the test updates in #5116 but it is still WIP.

Instead keep selected disks if they are still usable.

Relevant to https://bugzilla.redhat.com/show_bug.cgi?id=2231357#c3

Co-authored by: Radek Vykydal <rvykydal@redhat.com>
@KKoukiou KKoukiou marked this pull request as ready for review September 4, 2023 10:13
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Sep 4, 2023

/kickstart-test --waive webui-only

@KKoukiou KKoukiou merged commit 70c7b06 into rhinstaller:master Sep 4, 2023
12 checks passed
@KKoukiou KKoukiou deleted the webui-rescan-no-unselect branch September 4, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants