Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webui rescan keep selection #5116

Closed
wants to merge 2 commits into from
Closed

Webui rescan keep selection #5116

wants to merge 2 commits into from

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Sep 1, 2023

No description provided.

@rvykydal rvykydal marked this pull request as draft September 1, 2023 15:05
@rvykydal rvykydal mentioned this pull request Sep 4, 2023
Merged
@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 4, 2023 •
edited
Loading

The failing test TestStorageMountPoints.testBtrfsSubvolumes works for me run individually locally.
If I run the whole suite (--jobs 2) locally I see some instability of the tests. In one run 1 test failed on s.check_pw_strength("strong"), in another run the same test as here failed in another place - self.select_mountpoint(b, i, s, [(dev, True)]). But I am not not hitting this specific failure :(

I guess get_disk_selected is racy with my modification.

@KKoukiou
Copy link
Contributor

KKoukiou commented Sep 4, 2023

Tests on #5078 are now passing (cherry-picked) your changes there, so I guess we can merge that one.

@rvykydal rvykydal closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
f40 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvykydal @KKoukiou