bootupd: Use --write-uuid #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
I didn't test this locally (still don't have an anaconda devenv) but hopefully someone can sanity check this. |
|
@cgwalters Can you fix the unit tests, please? It should be a one-liner. @VladimirSlavik is working on integrations tests. We can try them on your pull request tomorrow. Btw. we are able to generate a boot.iso from your pull request if you want to play with it. |
This is an even newer behavior that takes over handling of the "UUID stamp files", which we want in general instead of using the static labels. Note `--write-uuid` implies `--with-static-configs`. This should fix this use case: ``` clearpart --all --initlabel --disklabel=gpt reqpart --add-boot part / --grow --fstype xfs ``` Whereas right now we require: ``` clearpart --all --initlabel --disklabel=gpt reqpart part /boot --size=1000 --fstype=ext4 --label=boot part / --grow --fstype xfs ``` Specifically the `--label=boot`.
cgwalters
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-test --testtype smoke |
SGTM yes! |
|
Turns out, the tests are not exactly easy to adapt for ostree and reboot at once :( |
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 15, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
poncovka
approved these changes
Dec 15, 2023
|
Tested manually. It seems to work, so I am merging this pull request. There should be a new release on Tuesday. |
|
Thanks! I just wanted to briefly explain here for the record; it may be obvious to some but still: the reason we need a distinction between the two In the CoreOS case there's logic that runs in the initramfs at boot time to generate the UUIDs. So the logic today in coreos-assembler (that is now being replicated in osbuild) will use In this we are assuming Anaconda is not used to make "generic" images. That said it doesn't really matter too much...I honestly want to try really hard to get away from the "coreos-installer" type "dd raw disk image" for bare metal installs because there are just so many traps/problems (e.g. 4kn disks...) |
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 20, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 20, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 20, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 20, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 20, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 20, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 20, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Dec 21, 2023
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
supakeen
added a commit
to supakeen/images
that referenced
this pull request
Jan 5, 2024
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Jan 5, 2024
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an even newer behavior that takes over handling of the "UUID stamp files", which we want in general instead of using the static labels.
Note
--write-uuidimplies--with-static-configs.This should fix this use case:
Whereas right now we require:
Specifically the
--label=boot.