Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating encoding.h, added test for mconfigptr #377

Closed
wants to merge 9 commits into from
Closed

updating encoding.h, added test for mconfigptr #377

wants to merge 9 commits into from

Conversation

dansmathers
Copy link
Contributor

Description

Add read-only CSR MCONFIGPTR test (1 read/1 write).

Related Issues

Requires sail update for signatures to pass: riscv/sail-riscv#293

Ratified/Unratified Extensions

  • Ratified
  • Unratified

List Extensions

MCONFIGPTR exists in the priv spec 1.12 and used by the discovery task group.

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • [ X] All tests are compliant with the test-format spec present in this repo ?
  • [ X] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
    requires Add read-only CSR MCONFIGPTR riscv/sail-riscv#293 and reference this issue to workaround SAIL compile issue: sail compile temp broken. riscv/sail-riscv#292
  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

description of ssclint tests
RVTEST_CASE contains the toolchain command.   Check ISA is for selecting tests.  Added Smclint to check ISA so these tests are only selected when included in the dut isa yaml.
add comments about smclint and ssclint
mconfigptr is used by the unified discovery task group https://github.com/riscv/configuration-structure and already exists in priv spec 1.12.
added comment that a csr write to a read-only csr is expected to cause an exception
did a subtract of first csr read with 2nd csr read after write.  expected signature of 0.
@dansmathers
Copy link
Contributor Author

closing. Not sure how to have more than one fork at a time. since these are technical debt, no rush. will open a new pull for smcsrind.

@dansmathers dansmathers deleted the dansmathers-patch-1 branch August 28, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant