-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Memory SV-32 Address Translation Scheme Tests and Covergroups #516
base: dev
Are you sure you want to change the base?
Virtual Memory SV-32 Address Translation Scheme Tests and Covergroups #516
Conversation
Signed-off-by: Muhammad Hammad Bashir <139617104+MuhammadHammad001@users.noreply.github.com>
Signed-off-by: Muhammad Hammad Bashir <139617104+MuhammadHammad001@users.noreply.github.com>
@allenjbaum CI is passing for these tests too, please review these tests. |
@allenjbaum @UmerShahidengr Covergroups have been updated and now are written using the translator format. |
Signed-off-by: Muhammad Hammad Bashir <139617104+MuhammadHammad001@users.noreply.github.com>
Hi @allenjbaum @UmerShahidengr few more tests and covergroups have been added. Please review this Test Plan as well and please let me know the cases that I have marked as NOT Possible can be achieved or not. Else these tests are complete and need your kind review |
#check mstatus has: case1: MPP& U in MPP and case2: MPP& S in MPP | ||
mstatus == {0x00020000, 0x00020800}: 0 | ||
val_comb: | ||
'mode == "M" and (mstatus == {0x00020000, 0x00020800}) and get_pte_prop({"ADURWXV", "ADuRWXV"}{[$1]}, dptw1cont) == 1 and dptw0cont == None': 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't be using numeric constants. use MSTATUS_MPRV and MSTATUS_MPP_S (you'll need to define that latter). You could define MSTATUS_MPP_U (==0) and MSTATUS_MPP_M (==MSTATUS_MPP) also to make it clearer
Description
This PR contains the tests and covergroups for Virtual Memory SV32 address translation scheme. The tests and covergroups are written using the following Test Plan
Related Issues
This PR has a dependency on the PR# 563.
Ratified/Unratified Extensions
List Extensions
NA
Reference Model Used
Mandatory Checklist:
Optional Checklist: