[vector-crypto] Fixing Zvkb/Zvbb distinction #1474
Conversation
disasm/disasm.cc
Outdated
| @@ -2233,38 +2233,43 @@ void disassembler_t::add_instructions(const isa_parser_t* isa) | |||
| DEFINE_R1TYPE(sm3p1); | |||
| } | |||
|
|
|||
| if (isa->extension_enabled(EXT_ZVBB)) { | |||
| if (isa->extension_enabled(EXT_ZVKB) || isa->extension_enabled(EXT_ZVBB)) { | |||
There was a problem hiding this comment.
Not sure if this is the accepted way to condition instructions shared between two extensions.
There was a problem hiding this comment.
You only need to check for Zvkb because of this line, which guarantees that if Zvbb is present then Zvkb is also present.
There was a problem hiding this comment.
Makes sense, I should have read the code I changed ...
nibrunie
force-pushed
the
vector-crypto-zvkb
branch
from
34bd6bd
to
8391771
Compare
|
@nibrunieAtSi5 , @nibrunie Hi, are you still going to finish this? This feature would be really nice to have, and I was going to implement it myself, but then I noticed your commit. |
Yes I need to revive this. I will try to get it up for review this week (July 8th 2024). |
nibrunieAtSi5
force-pushed
the
vector-crypto-zvkb
branch
from
8391771
to
63bd01d
Compare
Signed-off-by: Nicolas Brunie <82109999+nibrunieAtSi5@users.noreply.github.com>
Signed-off-by: Nicolas Brunie <82109999+nibrunieAtSi5@users.noreply.github.com>
nibrunieAtSi5
force-pushed
the
vector-crypto-zvkb
branch
from
63bd01d
to
6a31dc2
Compare
It looks like vector crypto support introduced in #1303 was made before the
Zvkbwas re-introduced as a subset ofZvbb.Working on fixing this here.