-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Zcb extension #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not checked the encodings are correct, but the code LGTM.
I'm not sure we actually need this command line flag (especially if you're not actually using it).
This adds an implementation of the Zcb code size extension. Co-authored-by: Martin Berger <martinberger@users.noreply.github.com>
I mainly added it for other people to use and to reduce the merge conflicts for us. I think it's worth keeping for when/if we eventually actually use |
I'm guessing a lot of this command line parsing will go away eventually, so if it makes things easier for you merging as is sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds an implementation of the Zcb code size extension.
This fixes all of the comments on the previous PR #322 - and also adds flags to the emulator to enable the extension (it is disabled by default).