Require Sail version 0.18 #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be worth temporarily adding a note to the README explaining the unknown option error message since it will be quite common this first time around. |
arichardson
approved these changes
Sep 4, 2024
jordancarlin
approved these changes
Sep 5, 2024
Timmmm
force-pushed
the
user/timh/version_check
branch
from
22737a2
to
cda39e7
Compare
Alasdair
approved these changes
Sep 9, 2024
Use the new `--require-version` flag to set the minimum version to 0.18 (the current latest release). If you have an older version that supports this flag you'll get an error like
Sail version 0.17.1 is older than requested version 0.18
Currently there actually aren't any older versions that support this flag (unless you compiled from source) so you'd get this error instead:
sail: unknown option '--require-version'.
Not ideal, but the problem will solve itself eventually so I don't think it's worth worrying about for now. I added a brief note to the README about it though.
Timmmm
force-pushed
the
user/timh/version_check
branch
from
cda39e7
to
d760b9e
Compare
Timmmm
pushed a commit
to Timmmm/sail-riscv
that referenced
this pull request
Oct 2, 2024
Check the mcontrol triggers, no other triggers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
--require-versionflag to set the minimum version to 0.18 (the current latest release). If you have an older version that supports this flag you'll get an error likeCurrently there actually aren't any older versions that support this flag (unless you compiled from source) so you'd get this error instead:
Not ideal, but the problem will solve itself eventually so I don't think it's worth worrying about for now.