-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Angular Accelerometer and Linear Velocity Sensor Interfaces to the Sensor Remapper #3149
Conversation
nicktrem
commented
Nov 13, 2024
- This PR will allow the angular acceleration and linear velocity measurements measured by a particular sensor to be extracted and used via the sensor remapper.
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
|
@nicktrem I see that there are some conflicts, probably you can look into solving them. For the conflict in the autogenerated files, it is probably easier if you just regenerated them once you solved the other conflicts. |
cmake/YarpIDL.cmake
Outdated
@@ -193,7 +193,7 @@ endfunction() | |||
function(YARP_IDL_TO_DIR) | |||
|
|||
# Flag to control whether IDL generation is allowed. | |||
option(ALLOW_IDL_GENERATION "Allow YARP to (re)build IDL files as needed" OFF) | |||
option(ALLOW_IDL_GENERATION "Allow YARP to (re)build IDL files as needed" ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value should not be modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3c5625e
Is this PR complete? @nicktrem @traversaro |
ThreeAxisAngularAccelerometers=2, | ||
ThreeAxisMagnetometers=3, | ||
OrientationSensors=4, | ||
TemperatureSensors=5, | ||
SixAxisForceTorqueSensors=6, | ||
ContactLoadCellArrays=7, | ||
EncoderArrays=8, | ||
SkinPatches=9, | ||
PositionSensors=10, | ||
LinearVelocitySensors=11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just add the new value at the end for avoiding changing the value of the constants unless strictly necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8ec2a36
My only blocking comment is https://github.com/robotology/yarp/pull/3149/files#r1856392918 . Beside that, this introduces a communication incompatibility between YARP 3.10 and YARP master for |
The development of this branch has been completed. I have marked this PR as ready to review. @randaz81 @traversaro please let me know if there are any additional requests, Thanks! |
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Quality Gate failedFailed conditions |
@randaz81 for me the PR is good to go. |