Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup FindOpenCV.cmake and deprecate OpenCV_LIBRARIES in favor of OpenCV_LIBS #434

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

traversaro
Copy link
Member

FindOpenCV.cmake contains a lot of legacy logic that is not useful for any OpenCV version >= 3, and that takes a lot of time if find_package(OpenCV) is called in a system without OpenCV. This PR removes the legacy logic, and deprecated the FindOpenCV.cmake module YCM, as downstream users should be able to just use the regular OpenCVConfig.cmake installed directly by CMake. As a consequence of this, downstream users should switch from OpenCV_LIBRARIES to OpenCV_LIBS.

@traversaro traversaro changed the title Cleanup and deprecate FindOpenCV.cmake Cleanup FindOpenCV.cmake and deprecate OpenCV_LIBRARIES in favor of OpenCV_LIBS Nov 16, 2023
@traversaro traversaro requested a review from Nicogene November 16, 2023 13:04
@Nicogene
Copy link
Member

@pattacini we should adapt which repository uses OpenCV_LIBRARIES:

@traversaro traversaro merged commit a73a4df into master Nov 16, 2023
6 of 8 checks passed
@traversaro traversaro deleted the traversaro-patch-1 branch November 16, 2023 13:14
@pattacini
Copy link
Member

@pattacini we should adapt which repository uses OpenCV_LIBRARIES:

Yes, definitely, but it's not for this distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants