test: add at_least_until to have_no_new_sample #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doudou Did you miss this one? |
doudou
reviewed
Jun 4, 2020
| @@ -27,7 +27,7 @@ def self.resolve_orocos_reader(reader, **policy) | |||
| # | |||
| # Implementation of the {#have_no_new_sample} predicate | |||
| class HaveNoNewSample < Roby::Test::ExecutionExpectations::Maintain | |||
| def initialize(reader, at_least_during, description, backtrace) | |||
| def initialize(reader, at_least, description, backtrace) | |||
There was a problem hiding this comment.
Same remark about splitting at_least_during / at_least_until in the constructor.
|
Forgot to click on "submit review" :( |
|
Hi @g-arjones, do you plan to continue working on this PR ? |
|
Hey.. I do, yes (unless you want to takeover and finish it). It is on the bottom of my TODO list though |
|
OK. Just to know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: