object oriented re-write #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for a long time I was not sure why I would get very slightly different results if I predicted row by row in a dataset versus the whole thing. It turned out to be an issue in the predict_value routine where the case of the final value in pred_leaf being a unique leaf would lead to that value getting the leaf data from the prior leaf. I had to introduce several new features into the predict function to catch this error and those features now need to be ironed out.
|
🍾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ code has been reworked following the design of
rangerto allow for object-oriented programming, which should make it much easier to develop classification/regression trees and implement multi-threading.