Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for CRAN resubmission #328

Merged
merged 18 commits into from
Sep 24, 2024
Merged

Fixes for CRAN resubmission #328

merged 18 commits into from
Sep 24, 2024

Conversation

b-rodrigues
Copy link
Contributor

@b-rodrigues
Copy link
Contributor Author

b-rodrigues commented Sep 23, 2024

I think that the commit cdffb86 deals with the DESCRIPTION file (title, and write software names with single quotes). AFAIK, the point regarding references is not relevant here? Or should we cite Eelco's paper on Nix? We could I guess.
The final point I think might be a misunderstanding: they functions don't write by default, since overwrite = FALSE. The user needs to explicitly set this argument to TRUE, so I think we need to explain this in cran-comments.md.

@b-rodrigues
Copy link
Contributor Author

b-rodrigues commented Sep 23, 2024

In case we want to cite Eelco's paper:

Eelco et al. (2004) <doi:10.5555/1052676.1052686>

what do you think @philipp-baumann ?

Copy link
Collaborator

@philipp-baumann philipp-baumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproducible Software Environments with 'Nix'

DESCRIPTION Outdated Show resolved Hide resolved
R/nix_build.R Outdated Show resolved Hide resolved
b-rodrigues and others added 2 commits September 24, 2024 11:05
Co-authored-by: Philipp Baumann <baumann-philipp@protonmail.com>
@philipp-baumann
Copy link
Collaborator

@b-rodrigues there are a couple of lint problems that need a manual fix

let's use

# nolint start: line_length_linter
# nolint end

or

# nolint next: line_length_linter

or

# nolint

if stuff cannot be broken down to 100 characters (urls)...

@philipp-baumann
Copy link
Collaborator

In case we want to cite Eelco's paper:

Eelco et al. (2004) <doi:10.5555/1052676.1052686>

what do you think @philipp-baumann ?

yeah sure, sounds good to me!

R/rix.R Outdated
@@ -156,7 +156,7 @@ rix <- function(r_ver = "latest",
local_r_pkgs = NULL,
tex_pkgs = NULL,
ide = c("other", "code", "radian", "rstudio", "rserver"),
project_path,
project_path = getwd(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s not going to fly:

Please ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). This is not allowed by CRAN policies.
Please omit any default path in writing functions. In your
examples/vignettes/tests you can write to tempdir().
-> R/rix.R; R/rix_init.R

it’s ok for nix_build() because it’s not writing, only looking for a default.nix

@philipp-baumann
Copy link
Collaborator

@b-rodrigues ready for your review ;-)

@b-rodrigues b-rodrigues merged commit ce457db into main Sep 24, 2024
7 checks passed
@b-rodrigues b-rodrigues deleted the cran_resub branch September 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants