-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CRAN resubmission #328
Conversation
I think that the commit cdffb86 deals with the DESCRIPTION file (title, and write software names with single quotes). AFAIK, the point regarding references is not relevant here? Or should we cite Eelco's paper on Nix? We could I guess. |
In case we want to cite Eelco's paper:
what do you think @philipp-baumann ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproducible Software Environments with 'Nix'
Co-authored-by: Philipp Baumann <baumann-philipp@protonmail.com>
@b-rodrigues there are a couple of lint problems that need a manual fix let's use # nolint start: line_length_linter
# nolint end or # nolint next: line_length_linter or
if stuff cannot be broken down to 100 characters (urls)... |
yeah sure, sounds good to me! |
2d67e8a
to
83757b5
Compare
R/rix.R
Outdated
@@ -156,7 +156,7 @@ rix <- function(r_ver = "latest", | |||
local_r_pkgs = NULL, | |||
tex_pkgs = NULL, | |||
ide = c("other", "code", "radian", "rstudio", "rserver"), | |||
project_path, | |||
project_path = getwd(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s not going to fly:
Please ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). This is not allowed by CRAN policies.
Please omit any default path in writing functions. In your
examples/vignettes/tests you can write to tempdir().
-> R/rix.R; R/rix_init.R
it’s ok for nix_build() because it’s not writing, only looking for a default.nix
2ea3683
to
fe4864c
Compare
@b-rodrigues ready for your review ;-) |
#327