-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CRAN resubmission #328
Merged
Merged
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8ab8efc
fixes #325
cdffb86
dealt with CRAN comments
0f92911
writing to tempfile() instead of '.'
ad091a6
removed default path for project_path
1cc58c0
updated cran-comments
9938684
Update nix_build.R
b-rodrigues 9cd8fcc
Update DESCRIPTION
b-rodrigues 74aac0d
Update R/nix_build.R
b-rodrigues 83757b5
please linter
0434fc7
default proj path to working dir
4256c90
no default writing path, revert to please policy
f9c8fc5
always commit when styling
67c441b
also add formatted .Rmd
fe4864c
better desc?
d9c9906
improved desc
72fceff
missing tick
b69a7a7
Style via {styler}
philipp-baumann 0c093b9
Update cran-comments.md
b-rodrigues File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
#' sysdata | ||
#' | ||
#' Nix revisions with old R releases | ||
#' 'Nix' revisions with old R releases | ||
#' | ||
#' @format A data frame with 39 rows and 3 variables: | ||
#' \describe{ | ||
#' \item{ version }{ R version } | ||
#' \item{ revision }{ Nix revision containing this version of R } | ||
#' \item{ date }{ Date when this revision was available } | ||
#' } | ||
#' @source Nix Package Version, by Marcelo Lazaroni | ||
#' @source 'Nix' Package Version, by Marcelo Lazaroni | ||
#' @noRd | ||
"available_r" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s not going to fly:
it’s ok for nix_build() because it’s not writing, only looking for a default.nix