Fix dependencies for source build (#1533) (#1536)

* Don't use std::system call inside test

* Give launch_ros as explicit dependency

* Test the source build on this branch

* Revert "Test the source build on this branch"

This reverts commit 9884b11.

(cherry picked from commit e260049)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

controller_interface/test/test_controller_interface.cpp

@@ -82,7 +82,8 @@ TEST(TestableControllerInterface, setting_update_rate_in_configure)
   ASSERT_EQ(controller.get_update_rate(), 2812u);
 
   // Test updating of update_rate parameter
-  EXPECT_EQ(std::system("ros2 param set /testable_controller_interface update_rate 623"), 0);
+  auto res = controller.get_node()->set_parameter(rclcpp::Parameter("update_rate", 623));
+  EXPECT_EQ(res.successful, true);
   // Keep the same update rate until transition from 'UNCONFIGURED' TO 'INACTIVE' does not happen
   controller.configure();  // No transition so the update rate should stay intact
   ASSERT_NE(controller.get_update_rate(), 623u);

joint_limits/package.xml

@@ -18,6 +18,7 @@
   <depend>rclcpp_lifecycle</depend>
   <depend>urdf</depend>
 
+  <test_depend>launch_ros</test_depend>
   <test_depend>launch_testing_ament_cmake</test_depend>
   <test_depend>ament_cmake_gtest</test_depend>