Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
  • Loading branch information
saikishor and christophfroehlich authored Jul 30, 2024
1 parent 7f9b51b commit cf12b2f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions controller_manager/src/controller_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ controller_interface::ControllerInterfaceBaseSharedPtr ControllerManager::load_c
controller_interface::return_type ControllerManager::unload_controller(
const std::string & controller_name)
{
RCLCPP_INFO(get_logger(), "Unloading controller : '%s'", controller_name.c_str());
RCLCPP_INFO(get_logger(), "Unloading controller: '%s'", controller_name.c_str());
std::lock_guard<std::recursive_mutex> guard(rt_controllers_wrapper_.controllers_lock_);
std::vector<ControllerSpec> & to = rt_controllers_wrapper_.get_unused_list(guard);
const std::vector<ControllerSpec> & from = rt_controllers_wrapper_.get_updated_list(guard);
Expand Down Expand Up @@ -637,7 +637,7 @@ std::vector<ControllerSpec> ControllerManager::get_loaded_controllers() const
controller_interface::return_type ControllerManager::configure_controller(
const std::string & controller_name)
{
RCLCPP_INFO(get_logger(), "Configuring controller : '%s'", controller_name.c_str());
RCLCPP_INFO(get_logger(), "Configuring controller: '%s'", controller_name.c_str());

const auto & controllers = get_loaded_controllers();

Expand Down Expand Up @@ -2154,12 +2154,12 @@ void ControllerManager::read(const rclcpp::Time & time, const rclcpp::Duration &
}
RCLCPP_ERROR(
get_logger(),
"Deactivating following hardware components as their read cycle resulted in an error : [ %s]",
"Deactivating following hardware components as their read cycle resulted in an error: [ %s]",
failed_hardware_string.c_str());
RCLCPP_ERROR_EXPRESSION(
get_logger(), !stop_request_string.empty(),
"Deactivating following controllers as their hardware components read cycle resulted in an "
"error : [ %s]",
"error: [ %s]",
stop_request_string.c_str());
std::vector<ControllerSpec> & rt_controller_list =
rt_controllers_wrapper_.update_and_get_used_by_rt_list();
Expand Down Expand Up @@ -2324,13 +2324,13 @@ void ControllerManager::write(const rclcpp::Time & time, const rclcpp::Duration
}
RCLCPP_ERROR(
get_logger(),
"Deactivating following hardware components as their write cycle resulted in an error : [ "
"Deactivating following hardware components as their write cycle resulted in an error: [ "
"%s]",
failed_hardware_string.c_str());
RCLCPP_ERROR_EXPRESSION(
get_logger(), !stop_request_string.empty(),
"Deactivating following controllers as their hardware components write cycle resulted in an "
"error : [ %s]",
"error: [ %s]",
stop_request_string.c_str());
std::vector<ControllerSpec> & rt_controller_list =
rt_controllers_wrapper_.update_and_get_used_by_rt_list();
Expand Down

0 comments on commit cf12b2f

Please sign in to comment.