Issue 339: Implement parse_bool and refactor a few #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
bmagyar,
destogl,
erickisos,
homalozoa,
livanov93 and
sgmurray
bmagyar
reviewed
May 9, 2023
bmagyar
reviewed
May 9, 2023
bmagyar
reviewed
May 9, 2023
bmagyar
reviewed
May 9, 2023
bmagyar
changed the title
bmagyar
reviewed
May 10, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 34.61% 32.70% -1.92%
==========================================
Files 52 91 +39
Lines 2981 9553 +6572
Branches 1855 6433 +4578
==========================================
+ Hits 1032 3124 +2092
- Misses 310 704 +394
- Partials 1639 5725 +4086
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
May 10, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 11, 2023
(cherry picked from commit c9709f3) # Conflicts: # hardware_interface/src/component_parser.cpp # hardware_interface/src/mock_components/generic_system.cpp
bmagyar
added a commit
that referenced
this pull request
May 29, 2023
…1018) * Implement parse_bool and refactor a few (#1014) (cherry picked from commit c9709f3) # Conflicts: # hardware_interface/src/component_parser.cpp # hardware_interface/src/mock_components/generic_system.cpp * Alex fixed conflicts Co-authored-by: Alejandro Bordallo <alex.bordallo@gmail.com> --------- Co-authored-by: Alejandro Bordallo <alex.bordallo@gmail.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
flochre
pushed a commit
to flochre/ros2_control
that referenced
this pull request
Jul 5, 2023
…rols#1014) (ros-controls#1018) * Implement parse_bool and refactor a few (ros-controls#1014) (cherry picked from commit c9709f3) # Conflicts: # hardware_interface/src/component_parser.cpp # hardware_interface/src/mock_components/generic_system.cpp * Alex fixed conflicts Co-authored-by: Alejandro Bordallo <alex.bordallo@gmail.com> --------- Co-authored-by: Alejandro Bordallo <alex.bordallo@gmail.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bence told me to do this. Fixes #339